Merge pull request #3 from oesteban/fix/nipype-et-patch

enh: simplify nipype etelemetry ping handling

Author: mgxd

fmriprep/config.py

@@ -67,8 +67,13 @@
     :py:class:`~bids.layout.BIDSLayout`, etc.)
 
 """
+import os
 from multiprocessing import set_start_method
 
+# Disable NiPype etelemetry always
+_disable_et = bool(os.getenv("NO_ET") is not None or os.getenv("NIPYPE_NO_ET") is not None)
+os.environ["NIPYPE_NO_ET"] = "1"
+os.environ["NO_ET"] = "1"
 
 try:
     set_start_method('forkserver')
@@ -77,7 +82,6 @@
 finally:
     # Defer all custom import for after initializing the forkserver and
     # ignoring the most annoying warnings
-    import os
     import sys
     import random
 
@@ -110,6 +114,16 @@
 
 DEFAULT_MEMORY_MIN_GB = 0.01
 
+# Ping NiPype eTelemetry once if env var was not set
+# workers on the pool will have the env variable set from the master process
+if not _disable_et:
+    # Just get so analytics track one hit
+    from contextlib import suppress
+    from requests import get as _get_url, ConnectionError, ReadTimeout
+    with suppress((ConnectionError, ReadTimeout)):
+        _get_url("https://rig.mit.edu/et/projects/nipy/nipype", timeout=0.05)
+
+# Execution environment
 _exec_env = os.name
 _docker_ver = None
 # special variable set in the container
@@ -244,8 +258,6 @@ class nipype(_Config):
 
     crashfile_format = 'txt'
     """The file format for crashfiles, either text or pickle."""
-    disable_telemetry = bool(os.getenv("NIPYPE_NO_ET") is None)
-    """Disable interface telemetry"""
     get_linked_libs = False
     """Run NiPype's tool to enlist linked libraries for every interface."""
     memory_gb = None
@@ -295,12 +307,6 @@ def init(cls):
             })
             ncfg.enable_resource_monitor()
 
-        if not cls.disable_telemetry:
-            # check for latest version
-            from nipype import check_latest_version
-            check_latest_version()
-            os.environ["NIPYPE_NO_ET"] = "1"
-
         # Nipype config (logs and execution)
         ncfg.update_config({
             'execution': {

setup.cfg

@@ -33,6 +33,7 @@ install_requires =
     psutil >= 5.4
     pybids >= 0.10.2
     pyyaml
+    requests
     sdcflows ~= 1.3.1
     smriprep ~= 0.6.1
     tedana >= 0.0.9a1, < 0.0.10