fix(tests): revise old parser tests and relocate properly

Author: oesteban

fmriprep/cli/parser.py

@@ -2,6 +2,7 @@
 # vi: set ft=python sts=4 ts=4 sw=4 et:
 """Parser."""
 import os
+import sys
 from .. import config
 
 
@@ -281,20 +282,20 @@ def _bids_filter(value):
 
     latest = check_latest()
     if latest is not None and currentv < latest:
-        config.loggers.cli.warning("""\
+        print("""\
 You are using fMRIPrep-%s, and a newer version of fMRIPrep is available: %s.
 Please check out our documentation about how and when to upgrade:
 https://fmriprep.readthedocs.io/en/latest/faq.html#upgrading""" % (
-            config.execution.version, latest))
+            currentv, latest), file=sys.stderr)
 
     _blist = is_flagged()
     if _blist[0]:
         _reason = _blist[1] or 'unknown'
-        config.loggers.cli.warning("""\
+        print("""\
 WARNING: Version %s of fMRIPrep (current) has been FLAGGED
 (reason: %s).
 That means some severe flaw was found in it and we strongly
-discourage its usage.""" % (config.execution.version, _reason))
+discourage its usage.""" % (config.execution.version, _reason), file=sys.stderr)
 
     return parser
 

fmriprep/cli/tests/test_parser.py

@@ -1,6 +1,9 @@
 """Test parser."""
+from packaging.version import Version
 import pytest
 from ..parser import _build_parser
+from .. import version as _version
+from ... import config
 
 MIN_ARGS = ['data/', 'out/', 'participant']
 
@@ -66,3 +69,48 @@ def test_memory_arg(tmp_path, argval, gb):
     opts = _build_parser().parse_args(args)
 
     assert opts.memory_gb == gb
+
+
+@pytest.mark.parametrize('current,latest', [
+    ('1.0.0', '1.3.2'),
+    ('1.3.2', '1.3.2')
+])
+def test_get_parser_update(monkeypatch, capsys, current, latest):
+    """Make sure the out-of-date banner is shown."""
+    expectation = Version(current) < Version(latest)
+
+    def _mock_check_latest(*args, **kwargs):
+        return Version(latest)
+
+    monkeypatch.setattr(config.execution, 'version', current)
+    monkeypatch.setattr(_version, 'check_latest', _mock_check_latest)
+
+    _build_parser()
+    captured = capsys.readouterr().err
+
+    msg = """\
+You are using fMRIPrep-%s, and a newer version of fMRIPrep is available: %s.
+Please check out our documentation about how and when to upgrade:
+https://fmriprep.readthedocs.io/en/latest/faq.html#upgrading""" % (current, latest)
+
+    assert (msg in captured) is expectation
+
+
+@pytest.mark.parametrize('flagged', [
+    (True, None),
+    (True, 'random reason'),
+    (False, None),
+])
+def test_get_parser_blacklist(monkeypatch, capsys, flagged):
+    """Make sure the blacklisting banner is shown."""
+    def _mock_is_bl(*args, **kwargs):
+        return flagged
+
+    monkeypatch.setattr(_version, 'is_flagged', _mock_is_bl)
+
+    _build_parser()
+    captured = capsys.readouterr().err
+
+    assert ('FLAGGED' in captured) is flagged[0]
+    if flagged[0]:
+        assert ((flagged[1] or 'reason: unknown') in captured)