Skip to content

Commit 6bc37f3

Browse files
authored
Merge pull request #826 from effigies/fix/1.3.x/build-config-and-ci
FIX: Build config and CI
2 parents b0ceaba + 8b3b958 commit 6bc37f3

File tree

4 files changed

+14
-27
lines changed

4 files changed

+14
-27
lines changed

.circleci/config.yml

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -423,17 +423,17 @@ jobs:
423423
steps:
424424
- checkout
425425
- run:
426-
name: Install build depends
427-
command: python -m pip install "setuptools>=40.8.0" "pip>=19" "twine<2.0" docutils
426+
name: Install pipx
427+
command: python -m pip install pipx
428428
- run:
429429
name: Build and check
430430
command: |
431-
python setup.py sdist
432-
python -m twine check dist/*
431+
pipx run build
432+
pipx run twine check dist/*
433433
- run:
434434
name: Validate version
435435
command: |
436-
THISVERSION=$( python get_version.py )
436+
THISVERSION=$( python3 get_version.py )
437437
python -m pip install dist/*.tar.gz
438438
mkdir empty
439439
cd empty
@@ -447,27 +447,17 @@ jobs:
447447
steps:
448448
- checkout
449449
- run:
450-
name: Install build depends
451-
command: python -m pip install "setuptools>=40.8.0" "pip>=19" "twine<2.0" docutils
450+
name: Install pipx
451+
command: python -m pip install pipx
452452
- run:
453453
name: Build and check
454454
command: |
455-
python setup.py check -r -s
456-
python setup.py sdist
457-
python -m twine check dist/*
458-
- run:
459-
name: Validate version
460-
command: |
461-
THISVERSION=$( python3 get_version.py )
462-
python -m pip install dist/*.tar.gz
463-
mkdir empty
464-
cd empty
465-
INSTALLED=$( python -c 'import niworkflows; print(niworkflows.__version__)' )
466-
test "${CIRCLE_TAG:-$THISVERSION}" == "$INSTALLED"
455+
pipx run build
456+
pipx run twine check dist/*
467457
- run:
468458
name: Upload to PyPi
469459
command: |
470-
python -m twine upload dist/*
460+
pipx run twine upload dist/*
471461
472462
deploy_docker:
473463
machine:

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
[build-system]
22
# Keep synchronized with the minimum version to install in setup.py
3-
requires = ["setuptools >= 30.4.0", "wheel"]
3+
requires = ["setuptools >= 40.8.0", "versioneer"]
4+
build-backend = "setuptools.build_meta"

setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ classifiers =
1111
Programming Language :: Python :: 3.9
1212
description = NeuroImaging Workflows provides processing tools for magnetic resonance images of the brain.
1313
license = 3-clause BSD
14-
license_file = LICENSE
14+
license_files = LICENSE
1515
long_description = file:README.rst
1616
long_description_content_type = text/x-rst; charset=UTF-8
1717
project_urls =

setup.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,10 @@
66
import versioneer
77

88
# Use setup_requires to let setuptools complain if it's too old for a feature we need
9-
# 30.3.0 allows us to put most metadata in setup.cfg
10-
# 30.4.0 gives us options.packages.find
119
# 40.8.0 includes license_file, reducing MANIFEST.in requirements
1210
#
13-
# To install, 30.4.0 is enough, but if we're building an sdist, require 40.8.0
14-
# This imposes a stricter rule on the maintainer than the user
1511
# Keep the installation version synchronized with pyproject.toml
16-
SETUP_REQUIRES = [f"setuptools >= {'40.8.0' if 'sdist' in sys.argv else '30.4.0'}"]
12+
SETUP_REQUIRES = ["setuptools >= 40.8.0"]
1713

1814
# This enables setuptools to install wheel on-the-fly
1915
if "bdist_wheel" in sys.argv:

0 commit comments

Comments
 (0)