Merge remote-tracking branch 'upstream/maint/1.3.x' into maint/1.4.x

Author: effigies

CHANGES.rst

@@ -156,6 +156,12 @@ A list of prominent changes can be found below. (With thanks to Lea Waller for t
     * ``NormalizeMotionParams`` now under ``confounds``.
     * ``FMRISummary``, ``CompCorVariancePlot``, ``ConfoundsCorrelationPlot`` from ``plotting``
 
+1.3.7 (March 31, 2022)
+======================
+Bug-fix release in the 1.3.x series
+
+* FIX: Use copy function that does not preserve mtime when creating fsaverage directories (#703)
+
 1.3.6 (March 09, 2022)
 ======================
 Bug-fix release in the 1.3.x series

niworkflows/interfaces/bids.py

@@ -24,7 +24,7 @@
 from collections import defaultdict
 from json import dumps, loads
 from pathlib import Path
-from shutil import copytree, rmtree
+import shutil
 from pkg_resources import resource_filename as _pkgres
 import re
 
@@ -913,10 +913,15 @@ def _run_interface(self, runtime):
 
             # Finesse is overrated. Either leave it alone or completely clobber it.
             if dest.exists() and self.inputs.overwrite_fsaverage:
-                rmtree(dest)
+                shutil.rmtree(dest)
             if not dest.exists():
                 try:
-                    copytree(source, dest)
+                    # Use copy instead of copy2; copy calls copymode while copy2 calls
+                    # copystat, which will preserve atime/mtime.
+                    # atime should *not* be copied to avoid triggering processes that
+                    # sweep un-accessed files.
+                    # If we want to preserve mtime, that will require a new copy function.
+                    shutil.copytree(source, dest, copy_function=shutil.copy)
                 except FileExistsError:
                     LOGGER.warning(
                         "%s exists; if multiple jobs are running in parallel"