Skip to content

Commit f6449de

Browse files
STY: Apply ruff/flake8-comprehensions preview rule C409
C409 Unnecessary list comprehension passed to `tuple()` (rewrite as a generator)
1 parent b7b4a69 commit f6449de

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

niworkflows/interfaces/bids.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -647,9 +647,7 @@ def _run_interface(self, runtime):
647647

648648
if self.inputs.check_hdr:
649649
hdr = nii.header
650-
curr_units = tuple(
651-
[None if u == 'unknown' else u for u in hdr.get_xyzt_units()]
652-
)
650+
curr_units = tuple(None if u == 'unknown' else u for u in hdr.get_xyzt_units())
653651
curr_codes = (int(hdr['qform_code']), int(hdr['sform_code']))
654652

655653
# Default to mm, use sec if data type is bold
@@ -1164,9 +1162,7 @@ def _run_interface(self, runtime):
11641162

11651163
if self.inputs.check_hdr:
11661164
hdr = nii.header
1167-
curr_units = tuple(
1168-
[None if u == 'unknown' else u for u in hdr.get_xyzt_units()]
1169-
)
1165+
curr_units = tuple(None if u == 'unknown' else u for u in hdr.get_xyzt_units())
11701166
curr_codes = (int(hdr['qform_code']), int(hdr['sform_code']))
11711167

11721168
# Default to mm, use sec if data type is bold

niworkflows/reports/core.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -454,9 +454,9 @@ def _process_orderings(orderings, layout):
454454
for bids_file in layout.get()
455455
}
456456
# remove the all None member if it exists
457-
none_member = tuple([None for k in orderings])
457+
none_member = tuple(None for k in orderings)
458458
if none_member in all_value_combos:
459-
all_value_combos.remove(tuple([None for k in orderings]))
459+
all_value_combos.remove(tuple(None for k in orderings))
460460
# see what values exist for each entity
461461
unique_values = [
462462
{value[idx] for value in all_value_combos} for idx in range(len(orderings))

0 commit comments

Comments
 (0)