WIP: Add integration testing and github actions #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Jun 5, 2025
petprep/workflows/pet/outputs.py
Outdated
Comment on lines
86
to
87
| if 'VolumeTiming' in timing_parameters: | ||
| timing_parameters['AcquisitionDuration'] = TA |
There was a problem hiding this comment.
I can't imagine you need this function at all, since there are no gaps in PET recording.
There was a problem hiding this comment.
Thanks for the feedback, Chris - in general, still need to remove a bunch of slice timing related stuff.
Removed handling of 'SliceTiming' information and dropped slice-timing correction logic. The function now simply reports 'SliceTimingCorrected': False and retains only relevant timing fields Simplified the unit test by removing the run_stc parameter and related configuration changes
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
Only test failing will be solved when a new version of niworkflows is released nipreps/niworkflows#951. Therefore, merging this now to main branch. Still need to fix spellchecks and style. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.