Skip to content

Commit 5345dd7

Browse files
committed
Merge pull request #87 from Eric89GXL/cleaner-normals
ENH: Cleaner normal calculation
2 parents 06ad2de + a2bf5cb commit 5345dd7

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

surfer/utils.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -193,11 +193,8 @@ def _compute_normals(rr, tris):
193193
#
194194
nn = np.zeros((npts, 3))
195195
for verts in tris.T: # note this only loops 3x (number of verts per tri)
196-
counts = np.bincount(verts, minlength=npts)
197-
reord = np.argsort(verts)
198-
vals = np.r_[np.zeros((1, 3)), np.cumsum(tri_nn[reord, :], 0)]
199-
idx = np.cumsum(np.r_[0, counts])
200-
nn += vals[idx[1:], :] - vals[idx[:-1], :]
196+
for idx in range(3): # x, y, z
197+
nn[:, idx] += np.bincount(verts, tri_nn[:, idx], minlength=npts)
201198
size = np.sqrt(np.sum(nn * nn, axis=1))
202199
size[size == 0] = 1.0 # prevent ugly divide-by-zero
203200
nn /= size[:, np.newaxis]

0 commit comments

Comments
 (0)