fix: more general error, path as string

Author: mgxd

heudiconv/queue.py

@@ -1,5 +1,6 @@
 import subprocess
 import sys
+import os
 
 import logging
 
@@ -32,7 +33,6 @@ def queue_conversion(pyscript, queue, studyid, queue_args=None):
             raise NotImplementedError("Queuing with %s is not supported", queue)
 
         args = sys.argv[1:]
-        print(sys.argv)
         # search args for queue flag
         for i, arg in enumerate(args):
             if arg in ["-q", "--queue"]:
@@ -51,7 +51,7 @@ def queue_conversion(pyscript, queue, studyid, queue_args=None):
         convertcmd = " ".join(args)
 
         # will overwrite across subjects
-        queue_file = 'heudiconv-%s.sh' % queue
+        queue_file = os.path.abspath('heudiconv-%s.sh' % queue)
         with open(queue_file, 'wt') as fp:
             fp.writelines(['#!/bin/bash\n', convertcmd, '\n'])
 

heudiconv/tests/test_queue.py

@@ -17,17 +17,16 @@ def test_queue_no_slurm(tmpdir, invocation):
     tmpdir.chdir()
     hargs = invocation.split(" ")
     hargs.extend(["-f", "reproin", "-b", "--minmeta", "--queue", "SLURM"])
-    print(hargs)
 
     # simulate command-line call
     _sys_args = sys.argv
     sys.argv = ['heudiconv'] + hargs
 
     try:
-        with pytest.raises(FileNotFoundError):
+        with pytest.raises(OSError):
             runner(hargs)
         # should have generated a slurm submission script
-        slurm_cmd_file = tmpdir / 'heudiconv-SLURM.sh'
+        slurm_cmd_file = (tmpdir / 'heudiconv-SLURM.sh').strpath
         assert slurm_cmd_file
         # check contents and ensure args match
         with open(slurm_cmd_file) as fp: