BF: Do not overwrite previously converted nifti files unless overwrite

I remember us fixing this in Austin but somehow that was not committed

Author: yarikoptic

heudiconv/convert.py

@@ -246,8 +246,8 @@ def convert(items, converter, scaninfo_suffix, custom_callable, with_prov,
             os.makedirs(prefix_dirname)
 
         for outtype in outtypes:
-            lgr.debug("Processing %d dicoms for output type %s",
-                     len(item_dicoms), outtype)
+            lgr.debug("Processing %d dicoms for output type %s. Overwrite=%s",
+                     len(item_dicoms), outtype, overwrite)
             lgr.debug("Includes the following dicoms: %s", item_dicoms)
 
             seqtype = op.basename(op.dirname(prefix)) if bids else None
@@ -291,6 +291,11 @@ def convert(items, converter, scaninfo_suffix, custom_callable, with_prov,
                         prov_files.append(prov_file)
 
                     tempdirs.rmtree(tmpdir)
+                else:
+                    raise RuntimeError(
+                        "was asked to convert into %s but destination already exists"
+                        % (outname)
+                    )
 
         if len(bids_outfiles) > 1:
             lgr.warning("For now not embedding BIDS and info generated "

tests/test_heuristics.py

@@ -11,6 +11,9 @@
 
 import pytest
 
+import logging
+lgr = logging.getLogger(__name__)
+
 try:
     from datalad.api import Dataset
 except ImportError:  # pragma: no cover
@@ -54,6 +57,10 @@ def test_dbic_bids_largely_smoke(tmpdir, heuristic, invocation):
     head = ds.repo.get_hexsha()
 
     # and if we rerun -- should fail
+    lgr.info(
+        "RERUNNING, expecting to FAIL since the same everything "
+        "and -c specified so we did conversion already"
+    )
     with pytest.raises(RuntimeError):
         runner(args)