ENH(TST): tests for loading heuristics

Author: yarikoptic

heudiconv/utils.py

@@ -303,7 +303,7 @@ def load_heuristic(heuristic):
             mod = import_module('heudiconv.heuristics.%s' % heuristic)
             mod.filename = mod.__file__.rstrip('co')  # remove c or o from pyc/pyo
         except Exception as exc:
-            raise RuntimeError(
+            raise ImportError(
                 "Failed to import heuristic %s: %s"
                 % (heuristic, exc)
             )

tests/test_utils.py

@@ -1,9 +1,14 @@
 import os
+import os.path as op
 from heudiconv.utils import (
     get_known_heuristics_with_descriptions,
-    get_heuristic_description
+    get_heuristic_description,
+    load_heuristic
 )
 
+import pytest
+from .utils import HEURISTICS_PATH
+
 
 def test_get_known_heuristics_with_descriptions():
     d = get_known_heuristics_with_descriptions()
@@ -21,4 +26,18 @@ def test_get_heuristic_description():
     assert '_ses-' in desc
     assert '_run-' in desc
     # and mention ReproNim ;)
-    assert 'ReproNim' in desc
+    assert 'ReproNim' in desc
+
+
+def test_load_heuristic():
+    by_name = load_heuristic('reproin')
+    from_file = load_heuristic(op.join(HEURISTICS_PATH, 'reproin.py'))
+
+    assert by_name
+    assert by_name.filename == from_file.filename
+
+    with pytest.raises(ImportError):
+        load_heuristic('unknownsomething')
+
+    with pytest.raises(ImportError):
+        load_heuristic(op.join(HEURISTICS_PATH, 'unknownsomething.py'))