Skip to content

Commit d47bc9c

Browse files
committed
deprecated warning for strptime_micr()
1 parent 77ba0b3 commit d47bc9c

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

heudiconv/tests/test_utils.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -182,14 +182,15 @@ def test_get_datetime() -> None:
182182
],
183183
)
184184
def test_strptime_micr(dt: str, fmt: str) -> None:
185-
target = datetime.strptime(dt, fmt)
186-
assert strptime_micr(dt, fmt) == target
187-
assert strptime_micr(dt, fmt + "[.%f]") == target
188-
assert strptime_micr(dt + ".0", fmt + "[.%f]") == target
189-
assert strptime_micr(dt + ".000000", fmt + "[.%f]") == target
190-
assert strptime_micr(dt + ".1", fmt + "[.%f]") == datetime.strptime(
191-
dt + ".1", fmt + ".%f"
192-
)
185+
with pytest.warns(DeprecationWarning):
186+
target = datetime.strptime(dt, fmt)
187+
assert strptime_micr(dt, fmt) == target
188+
assert strptime_micr(dt, fmt + "[.%f]") == target
189+
assert strptime_micr(dt + ".0", fmt + "[.%f]") == target
190+
assert strptime_micr(dt + ".000000", fmt + "[.%f]") == target
191+
assert strptime_micr(dt + ".1", fmt + "[.%f]") == datetime.strptime(
192+
dt + ".1", fmt + ".%f"
193+
)
193194

194195

195196
@pytest.mark.parametrize(

heudiconv/utils.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
cast,
3838
overload,
3939
)
40+
import warnings
4041

4142
lgr = logging.getLogger(__name__)
4243

@@ -683,6 +684,11 @@ def strptime_micr(date_string: str, fmt: str) -> datetime.datetime:
683684
'.\d+' regex and not if it does not.
684685
"""
685686

687+
warnings.warn(
688+
"strptime_micr() is deprecated, please use strptime() instead.",
689+
DeprecationWarning,
690+
stacklevel=2,
691+
)
686692
optional_micr = "[.%f]"
687693
if fmt.endswith(optional_micr):
688694
fmt = fmt[: -len(optional_micr)]

0 commit comments

Comments
 (0)