Skip to content

Commit e9800bb

Browse files
committed
fix: address yarik's comments
1 parent 1751a8a commit e9800bb

File tree

2 files changed

+11
-13
lines changed

2 files changed

+11
-13
lines changed

heudiconv/cli/run.py

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
import logging
1717
lgr = logging.getLogger(__name__)
1818

19-
INIT_MSG = "Running {packname} version {version}".format
19+
INIT_MSG = "Running {packname} version {version} latest {latest}".format
2020

2121

2222
def is_interactive():
@@ -99,16 +99,6 @@ def process_extra_commands(outdir, args):
9999

100100

101101
def main(argv=None):
102-
import etelemetry
103-
try:
104-
latest = etelemetry.get_project("nipy/heudiconv")
105-
except RuntimeError as e:
106-
print("Could not check for version updates: ", e)
107-
else:
108-
if latest and 'version' in latest:
109-
print("Your version: {0} Latest version: {1}".format(__version__,
110-
latest["version"]))
111-
112102
parser = get_parser()
113103
args = parser.parse_args(argv)
114104
# exit if nothing to be done
@@ -255,8 +245,16 @@ def process_args(args):
255245

256246
outdir = op.abspath(args.outdir)
257247

248+
import etelemetry
249+
try:
250+
latest = etelemetry.get_project("nipy/heudiconv")
251+
except Exception as e:
252+
lgr.warning("Could not check for version updates: ", e)
253+
latest = {"version": 'Unknown'}
254+
258255
lgr.info(INIT_MSG(packname=__packagename__,
259-
version=__version__))
256+
version=__version__,
257+
latest=latest["version"]))
260258

261259
if args.command:
262260
process_extra_commands(outdir, args)

heudiconv/info.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
'nipype>=1.0.0',
1515
'pathlib',
1616
'dcmstack>=0.7',
17-
'etelemetry'
17+
'etelemetry',
1818
]
1919

2020
TESTS_REQUIRES = [

0 commit comments

Comments
 (0)