TST: pass --random-seed to test runs, and verify that blows when --files and multiple --subjects

Author: yarikoptic

tests/test_heuristics.py

@@ -28,7 +28,7 @@ def test_smoke_converall(tmpdir):
     )
 
 
-@pytest.mark.parametrize('heuristic', [ 'dbic_bids', 'convertall' ])
+@pytest.mark.parametrize('heuristic', ['dbic_bids', 'convertall'])
 @pytest.mark.parametrize(
     'invocation', [
         "--files tests/data",    # our new way with automated groupping
@@ -38,18 +38,26 @@ def test_smoke_converall(tmpdir):
 @pytest.mark.skipif(Dataset is None, reason="no datalad")
 def test_dbic_bids_largely_smoke(tmpdir, heuristic, invocation):
     is_bids = True if heuristic == 'dbic_bids' else False
-    arg = "-f heuristics/%s.py -c dcm2niix -o %s" % (heuristic, tmpdir)
+    arg = "--random-seed 1 -f heuristics/%s.py -c dcm2niix -o %s" % (heuristic, tmpdir)
     if is_bids:
         arg += " -b"
     arg += " --datalad "
     args = (
         arg + invocation
     ).split(' ')
-    if heuristic != 'dbic_bids' and invocation == '--files tests/data':
-        # none other heuristic has mighty infotoids atm
-        with pytest.raises(NotImplementedError):
-            runner(args)
-        return
+
+    # Test some safeguards
+    if invocation == '--files tests/data':
+        # Multiple subjects must not be specified -- only a single one could
+        # be overridden from the command line
+        with pytest.raises(ValueError):
+            runner(args + ['--subjects', 'sub1', 'sub2'])
+
+        if heuristic != 'dbic_bids':
+            # none other heuristic has mighty infotoids atm
+            with pytest.raises(NotImplementedError):
+                runner(args)
+            return
     runner(args)
     ds = Dataset(str(tmpdir))
     assert ds.is_installed()