Added tests for decode_value function

Author: MarcCote

nibabel/streamlines/tests/test_trk.py

@@ -153,6 +153,17 @@ def test_load_file_with_wrong_information(self):
         new_trk_file = trk_file[:996] + hdr_size + trk_file[996+4:]
         assert_raises(HeaderError, TrkFile.load, BytesIO(new_trk_file))
 
+        # Simulate a TRK file with a wrong scalar_name.
+        trk_file = open(DATA['complex_trk_fname'], 'rb').read()
+        noise = np.int32(42).tostring()
+        new_trk_file = trk_file[:47] + noise + trk_file[47+4:]
+        assert_raises(HeaderError, TrkFile.load, BytesIO(new_trk_file))
+
+        # Simulate a TRK file with a wrong property_name.
+        noise = np.int32(42).tostring()
+        new_trk_file = trk_file[:254] + noise + trk_file[254+4:]
+        assert_raises(HeaderError, TrkFile.load, BytesIO(new_trk_file))
+
     def test_load_complex_file_in_big_endian(self):
         trk_file = open(DATA['complex_trk_big_endian_fname'], 'rb').read()
         # We use hdr_size as an indicator of little vs big endian.

nibabel/streamlines/trk.py

@@ -12,7 +12,7 @@
 import nibabel as nib
 
 from nibabel.openers import Opener
-from nibabel.py3k import asbytes, asstr
+from nibabel.py3k import asstr
 from nibabel.volumeutils import (native_code, swapped_code)
 from nibabel.orientations import (aff2axcodes, axcodes2ornt)
 
@@ -203,7 +203,7 @@ def decode_value_from_name(encoded_name):
     elif len(splits) > 2:
         # The remaining bytes are not \x00, raising.
         msg = ("Wrong scalar_name or property_name: '{}'."
-               " Unused characters should be \\x00.").format(name)
+               " Unused characters should be \\x00.").format(encoded_name)
         raise HeaderError(msg)
 
     return name, value