STY: Apply ruff rule RUF012

RUF012 Mutable class attributes should be annotated with `typing.ClassVar`

Co-authored-by: Chris Markiewicz <[email protected]>

Author: DimitriPapadopoulos

doc/tools/apigen.py

@@ -32,7 +32,7 @@ class ApiDocWriter:
     to Sphinx-parsable reST format"""
 
     # only separating first two levels
-    rst_section_levels = ['*', '=', '-', '~', '^']
+    rst_section_levels = ('*', '=', '-', '~', '^')
 
     def __init__(
         self,

nibabel/analyze.py

@@ -84,6 +84,8 @@
 
 from __future__ import annotations
 
+import typing as ty
+
 import numpy as np
 
 from .arrayproxy import ArrayProxy
@@ -92,6 +94,7 @@
 from .fileholders import copy_file_map
 from .spatialimages import HeaderDataError, HeaderTypeError, SpatialHeader, SpatialImage
 from .volumeutils import (
+    Recoder,
     apply_read_scaling,
     array_from_file,
     make_dt_codes,
@@ -185,7 +188,7 @@ class AnalyzeHeader(LabeledWrapStruct, SpatialHeader):
     template_dtype = header_dtype
     _data_type_codes = data_type_codes
     # fields with recoders for their values
-    _field_recoders = {'datatype': data_type_codes}
+    _field_recoders: ty.ClassVar[dict[str, Recoder]] = {'datatype': data_type_codes}
     # default x flip
     default_x_flip = True
 

nibabel/cifti2/cifti2.py

@@ -1045,14 +1045,6 @@ class Cifti2MatrixIndicesMap(xml.XmlSerializable, MutableSequence):
         If it is a series, units
     """
 
-    _valid_type_mappings_ = {
-        Cifti2BrainModel: ('CIFTI_INDEX_TYPE_BRAIN_MODELS',),
-        Cifti2Parcel: ('CIFTI_INDEX_TYPE_PARCELS',),
-        Cifti2NamedMap: ('CIFTI_INDEX_TYPE_LABELS',),
-        Cifti2Volume: ('CIFTI_INDEX_TYPE_SCALARS', 'CIFTI_INDEX_TYPE_SERIES'),
-        Cifti2Surface: ('CIFTI_INDEX_TYPE_SCALARS', 'CIFTI_INDEX_TYPE_SERIES'),
-    }
-
     def __init__(
         self,
         applies_to_matrix_dimension,

nibabel/nifti1.py

@@ -815,7 +815,7 @@ class Nifti1Header(SpmAnalyzeHeader):
     _data_type_codes = data_type_codes
 
     # fields with recoders for their values
-    _field_recoders = {
+    _field_recoders: ty.ClassVar[dict[str, Recoder]] = {
         'datatype': data_type_codes,
         'qform_code': xform_codes,
         'sform_code': xform_codes,

nibabel/openers.py

@@ -131,7 +131,7 @@ class Opener:
     gz_def = (_gzip_open, ('mode', 'compresslevel', 'mtime', 'keep_open'))
     bz2_def = (BZ2File, ('mode', 'buffering', 'compresslevel'))
     zstd_def = (_zstd_open, ('mode', 'level_or_option', 'zstd_dict'))
-    compress_ext_map: dict[str | None, OpenerDef] = {
+    compress_ext_map: ty.ClassVar[dict[str | None, OpenerDef]] = {
         '.gz': gz_def,
         '.bz2': bz2_def,
         '.zst': zstd_def,
@@ -141,7 +141,7 @@ class Opener:
     default_compresslevel = 1
     #: default option for zst files
     default_zst_compresslevel = 3
-    default_level_or_option = {
+    default_level_or_option: ty.ClassVar[dict[str, int | None]] = {
         'rb': None,
         'r': None,
         'wb': default_zst_compresslevel,

nibabel/wrapstruct.py

@@ -112,6 +112,8 @@
 
 from __future__ import annotations
 
+from typing import ClassVar
+
 import numpy as np
 
 from . import imageglobals as imageglobals
@@ -485,7 +487,7 @@ def _get_checks(klass):
 class LabeledWrapStruct(WrapStruct):
     """A WrapStruct with some fields having value labels for printing etc"""
 
-    _field_recoders: dict[str, Recoder] = {}  # for recoding values for str
+    _field_recoders: ClassVar[dict[str, Recoder]] = {}  # for recoding values for str
 
     def get_value_label(self, fieldname):
         """Returns label for coded field

nibabel/xmlutils.py

@@ -49,7 +49,7 @@ class XmlParser:
         CharacterDataHandler
     """
 
-    HANDLER_NAMES = ['StartElementHandler', 'EndElementHandler', 'CharacterDataHandler']
+    HANDLER_NAMES = ('StartElementHandler', 'EndElementHandler', 'CharacterDataHandler')
 
     def __init__(self, encoding='utf-8', buffer_size=35000000, verbose=0):
         """