Add tests, change print error to ValueError, test it

Author: Ben Cipollini

nibabel/gifti/gifti.py

@@ -453,7 +453,7 @@ def add_gifti_data_array(self, dataarr):
         if isinstance(dataarr, GiftiDataArray):
             self.darrays.append(dataarr)
         else:
-            print("dataarr paramater must be of tzpe GiftiDataArray")
+            raise ValueError("dataarr paramater must be of type GiftiDataArray")
 
     def remove_gifti_data_array(self, ith):
         """ Removes the ith data array element from the GiftiImage """

nibabel/gifti/tests/test_gifti.py

@@ -4,14 +4,17 @@
 
 import numpy as np
 
+from nibabel.gifti import giftiio
+
+from .test_giftiio import (DATA_FILE1, DATA_FILE2, DATA_FILE3, DATA_FILE4,
+                           DATA_FILE5, DATA_FILE6)
 from ..gifti import (GiftiImage, GiftiDataArray, GiftiLabel, GiftiLabelTable,
                      GiftiMetaData)
 from ...nifti1 import data_type_codes, intent_codes
-
+from ...testing import clear_and_catch_warnings
 from numpy.testing import (assert_array_almost_equal,
                            assert_array_equal)
 from nose.tools import (assert_true, assert_false, assert_equal, assert_raises)
-from ...testing import clear_and_catch_warnings
 
 
 def test_gifti_image():
@@ -127,3 +130,30 @@ def assign_rgba(gl, val):
     gl4 = GiftiLabel()
     assert_equal(len(gl4.rgba), 4)
     assert_true(np.all([elem is None for elem in gl4.rgba]))
+
+
+def test_print_summary():
+    for fil in [DATA_FILE1, DATA_FILE2, DATA_FILE3, DATA_FILE4,
+                            DATA_FILE5, DATA_FILE6]:
+        gimg = giftiio.read(fil)
+        gimg.print_summary()
+
+
+def test_gifti_coord():
+    from ..gifti import GiftiCoordSystem
+    gcs = GiftiCoordSystem()
+    assert_true(gcs.xform is not None)
+
+    # Smoke test
+    gcs.xform = None
+    gcs.print_summary()
+    gcs.to_xml()
+
+
+def test_gifti_image():
+    img = GiftiImage()
+    assert_true(img.darrays is not None)
+    assert_true(img.meta is not None)
+    assert_true(img.labeltable is not None)
+
+    assert_raises(ValueError, img.add_gifti_data_array, 'not-a-data-array')