Skip to content

Commit 31f8a59

Browse files
Apply suggestions from code review
Co-authored-by: Matthew Brett <[email protected]>
1 parent f328a9a commit 31f8a59

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

doc/source/devel/core_developer.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ When reviewing, focus on the following:
4848

4949
4. **Tests:** All contributions to the library *must* be tested, and
5050
each added line of code should be covered by at least one test. Good
51-
tests not only execute the code, but explores corner cases. It is tempting
51+
tests not only execute the code, but explore corner cases. It is tempting
5252
not to review tests, but please do so.
5353

5454
Other changes may be *nitpicky*: spelling mistakes, formatting,
@@ -119,7 +119,7 @@ merging, because:
119119
effort to bring up to Nibabel's standards, and the original
120120
contributor has moved on, and no other developer can be found to make the
121121
necessary changes; or
122-
- the pull request makes changes that do not align with our values, such as
122+
- the pull request makes changes that make maintenance harder, such as
123123
increasing the code complexity of a function significantly to implement a
124124
marginal speedup,
125125

@@ -157,7 +157,7 @@ resources such as:
157157
- Our `mailing
158158
list <https://mail.python.org/mailman/listinfo/neuroimaging>`__
159159

160-
You are not required to monitor all of the social resources.
160+
Please do monitor any of the resources above that you find helpful.
161161

162162
Acknowledgments
163163
===============

0 commit comments

Comments
 (0)