TEST: Might as well test the testers. Found a bug.

Author: effigies

nibabel/__init__.py

@@ -116,23 +116,19 @@ def test(label=None, verbose=1, extra_argv=None,
     if label is not None:
         raise NotImplementedError("Labels cannot be set at present")
 
-    try:
-        verbose = int(verbose)
-    except ValueError:
-        pass
-    else:
-        if verbose > 0:
-            args.append("-" + "v" * verbose)
-        elif verbose < 0:
-            args.append("-" + "q" * -verbose)
+    verbose = int(verbose)
+    if verbose > 0:
+        args.append("-" + "v" * verbose)
+    elif verbose < 0:
+        args.append("-" + "q" * -verbose)
 
     if extra_argv:
         args.extend(extra_argv)
     if doctests:
         args.append("--doctest-modules")
     if coverage:
         args.extend(["--cov", "nibabel"])
-    if raise_warnings:
+    if raise_warnings is not None:
         raise NotImplementedError("Warning filters are not implemented")
     if timer:
         raise NotImplementedError("Timing is not implemented")

nibabel/tests/test_init.py

@@ -0,0 +1,59 @@
+import nibabel as nib
+from pkg_resources import resource_filename
+import pytest
+from unittest import mock
+
+@pytest.mark.parametrize("verbose, v_args", [(-2, ["-qq"]),
+                                             (-1, ["-q"]),
+                                             (0, []),
+                                             (1, ["-v"]),
+                                             (2, ["-vv"])])
+@pytest.mark.parametrize("doctests", (True, False))
+@pytest.mark.parametrize("coverage", (True, False))
+def test_nibabel_test(verbose, v_args, doctests, coverage):
+    expected_args = v_args + ["--doctest-modules", "--cov", "nibabel", "--pyargs", "nibabel"]
+    if not doctests:
+        expected_args.remove("--doctest-modules")
+    if not coverage:
+        expected_args[-4:-2] = []
+
+    with mock.patch("pytest.main") as pytest_main:
+        nib.test(verbose=verbose, doctests=doctests, coverage=coverage)
+
+    args, kwargs = pytest_main.call_args
+    assert args == ()
+    assert kwargs == {"args": expected_args}
+
+
+def test_nibabel_test_errors():
+    with pytest.raises(NotImplementedError):
+        nib.test(label="fast")
+    with pytest.raises(NotImplementedError):
+        nib.test(raise_warnings=[])
+    with pytest.raises(NotImplementedError):
+        nib.test(timer=True)
+    with pytest.raises(ValueError):
+        nib.test(verbose="-v")
+
+
+def test_nibabel_bench():
+    expected_args = ["-c", "--pyargs", "nibabel"]
+
+    try:
+        expected_args.insert(1, resource_filename("nibabel", "benchmarks/pytest.benchmark.ini"))
+    except:
+        raise unittest.SkipTest("Not installed")
+
+    with mock.patch("pytest.main") as pytest_main:
+        nib.bench(verbose=0)
+
+    args, kwargs = pytest_main.call_args
+    assert args == ()
+    assert kwargs == {"args": expected_args}
+
+    with mock.patch("pytest.main") as pytest_main:
+        nib.bench(verbose=0, extra_argv=[])
+
+    args, kwargs = pytest_main.call_args
+    assert args == ()
+    assert kwargs == {"args": expected_args}