Skip to content

Commit 58b517c

Browse files
committed
Revert "Use write_dataset for pydicom < 0.9.9 compat"
This reverts commit bf75e49.
1 parent cf72525 commit 58b517c

File tree

2 files changed

+8
-22
lines changed

2 files changed

+8
-22
lines changed

nibabel/nifti1.py

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -462,25 +462,14 @@ def _unmangle(self,value):
462462

463463
def _mangle(self, value):
464464
bio=BytesIO()
465-
dio=DicomFileLike(bio)
466-
if self._preamble:
467-
dio.write(self._preamble) # blank 128 byte preamble
468-
_write_file_meta_info(dio, self._meta)
469-
470-
# Set file VR, endian. MUST BE AFTER writing META INFO (which changes to Explicit LittleEndian)
471-
dio.is_implicit_VR = self._is_implicit_VR
472-
dio.is_little_endian = self._is_little_endian
473-
474-
write_dataset(dio, value)
475-
# write_file(bio,value)
476-
dio.seek(0)
477-
return dio.read()
465+
write_file(bio,value)
466+
bio.seek(0)
467+
return bio.read()
478468

479469
try:
480470
from dicom.dataset import FileDataset
481471
from dicom.filereader import read_dataset,read_preamble,_read_file_meta_info
482-
from dicom.filewriter import write_dataset,_write_file_meta_info
483-
from dicom.filebase import DicomFileLike
472+
from dicom.filewriter import write_file
484473
from dicom.values import converters as dicom_converters
485474
import dicom.UID
486475
from io import BytesIO

nibabel/tests/test_nifti1.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1096,7 +1096,6 @@ def test_nifti_dicom_extension():
10961096
assert_equal(dcmext._guess_implicit_VR(),False)
10971097
assert_equal(dcmext._is_implicit_VR,False)
10981098
assert_equal(dcmext._is_little_endian,True)
1099-
assert_equal(dcmext._check_encoding(),(False,True))
11001099
assert_equal(dcmext.get_code(),2)
11011100
assert_equal(dcmext.get_content().PatientID, 'NiPy')
11021101
assert_equal(len(dcmext.get_content().values()), 1)
@@ -1109,7 +1108,6 @@ def test_nifti_dicom_extension():
11091108
assert_equal(dcmext._guess_implicit_VR(),True)
11101109
assert_equal(dcmext._is_implicit_VR,True)
11111110
assert_equal(dcmext._is_little_endian,True)
1112-
assert_equal(dcmext._check_encoding(),(True,True))
11131111
assert_equal(dcmext.get_code(),2)
11141112
assert_equal(dcmext.get_content().PatientID, 'NiPy')
11151113
assert_equal(len(dcmext.get_content().values()), 1)
@@ -1128,15 +1126,14 @@ def test_nifti_dicom_extension():
11281126
with open(dicom_file,'rb') as dim:
11291127
dcmbytes_full = dim.read()
11301128
dcmext = Nifti1DicomExtension(2,dcmbytes_full)
1131-
assert_equal(dcmext.get_code(),2)
11321129
assert_equal(dcmext._is_implicit_VR,True)
11331130
assert_equal(dcmext._is_little_endian,True)
1134-
assert_equal(dcmext._check_encoding(),(True,True))
1131+
assert_equal(dcmext.get_code(),2)
11351132
assert_equal(dcmext.get_content().PatientID, '1234')
11361133
assert_equal(len(dcmext.get_content().values()), 139)
1137-
assert_equal(
1138-
dcmext.get_content().file_meta.TransferSyntaxUID,
1139-
dicom.filereader.read_file_meta_info(dicom_file).TransferSyntaxUID)
1134+
# assert_equal(
1135+
# dcmext.get_content().file_meta,
1136+
# dicom.filereader.read_file_meta_info(dicom_file))
11401137
assert_equal(dcmext.get_sizeondisk() % 16, 0)
11411138

11421139
# make it round-tripable

0 commit comments

Comments
 (0)