Skip to content

Commit 71e3ccc

Browse files
committed
[REF] Removes keywordonly methods + functions
Uses built-in Python kw-only syntax (*) instead.
1 parent fcc5448 commit 71e3ccc

File tree

13 files changed

+15
-112
lines changed

13 files changed

+15
-112
lines changed

nibabel/analyze.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@
9595
from .fileholders import copy_file_map
9696
from .batteryrunners import Report
9797
from .arrayproxy import ArrayProxy
98-
from .keywordonly import kw_only_meth
9998

10099
# Sub-parts of standard analyze header from
101100
# Mayo dbh.h file
@@ -933,8 +932,7 @@ def set_data_dtype(self, dtype):
933932
self._header.set_data_dtype(dtype)
934933

935934
@classmethod
936-
@kw_only_meth(1)
937-
def from_file_map(klass, file_map, mmap=True, keep_file_open=None):
935+
def from_file_map(klass, file_map, *, mmap=True, keep_file_open=None):
938936
''' Class method to create image from mapping in ``file_map``
939937
940938
.. deprecated:: 2.4.1

nibabel/arrayproxy.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
from .deprecated import deprecate_with_version
3535
from .volumeutils import array_from_file, apply_read_scaling
3636
from .fileslice import fileslice, canonical_slicers
37-
from .keywordonly import kw_only_meth
3837
from . import openers
3938

4039

@@ -96,8 +95,7 @@ class ArrayProxy(object):
9695
order = 'F'
9796
_header = None
9897

99-
@kw_only_meth(2)
100-
def __init__(self, file_like, spec, mmap=True, keep_file_open=None):
98+
def __init__(self, file_like, spec, *, mmap=True, keep_file_open=None):
10199
"""Initialize array proxy instance
102100
103101
.. deprecated:: 2.4.1

nibabel/brikhead.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636

3737
from .arrayproxy import ArrayProxy
3838
from .fileslice import strided_scalar
39-
from .keywordonly import kw_only_meth
4039
from .spatialimages import (
4140
SpatialImage,
4241
SpatialHeader,
@@ -220,8 +219,7 @@ class AFNIArrayProxy(ArrayProxy):
220219
None
221220
"""
222221

223-
@kw_only_meth(2)
224-
def __init__(self, file_like, header, mmap=True, keep_file_open=None):
222+
def __init__(self, file_like, header, *, mmap=True, keep_file_open=None):
225223
"""
226224
Initialize AFNI array proxy
227225
@@ -504,8 +502,7 @@ class AFNIImage(SpatialImage):
504502
ImageArrayProxy = AFNIArrayProxy
505503

506504
@classmethod
507-
@kw_only_meth(1)
508-
def from_file_map(klass, file_map, mmap=True, keep_file_open=None):
505+
def from_file_map(klass, file_map, *, mmap=True, keep_file_open=None):
509506
"""
510507
Creates an AFNIImage instance from `file_map`
511508

nibabel/cifti2/cifti2.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
from ..dataobj_images import DataobjImage
2525
from ..nifti2 import Nifti2Image, Nifti2Header
2626
from ..arrayproxy import reshape_dataobj
27-
from ..keywordonly import kw_only_meth
2827
from warnings import warn
2928

3029

@@ -1389,8 +1388,7 @@ def nifti_header(self):
13891388
return self._nifti_header
13901389

13911390
@classmethod
1392-
@kw_only_meth(1)
1393-
def from_file_map(klass, file_map, mmap=True, keep_file_open=None):
1391+
def from_file_map(klass, file_map, *, mmap=True, keep_file_open=None):
13941392
""" Load a CIFTI-2 image from a file_map
13951393
13961394
Parameters

nibabel/dataobj_images.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
from .arrayproxy import is_proxy
1414
from .filebasedimages import FileBasedImage
15-
from .keywordonly import kw_only_meth
1615
from .deprecated import deprecate_with_version
1716

1817

@@ -420,8 +419,7 @@ def get_shape(self):
420419
return self.shape
421420

422421
@classmethod
423-
@kw_only_meth(1)
424-
def from_file_map(klass, file_map, mmap=True, keep_file_open=None):
422+
def from_file_map(klass, file_map, *, mmap=True, keep_file_open=None):
425423
''' Class method to create image from mapping in ``file_map``
426424
427425
.. deprecated:: 2.4.1
@@ -458,8 +456,7 @@ def from_file_map(klass, file_map, mmap=True, keep_file_open=None):
458456
raise NotImplementedError
459457

460458
@classmethod
461-
@kw_only_meth(1)
462-
def from_filename(klass, filename, mmap=True, keep_file_open=None):
459+
def from_filename(klass, filename, *, mmap=True, keep_file_open=None):
463460
'''Class method to create image from filename `filename`
464461
465462
.. deprecated:: 2.4.1

nibabel/ecat.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@
5454
from .arraywriters import make_array_writer
5555
from .wrapstruct import WrapStruct
5656
from .fileslice import canonical_slicers, predict_shape, slice2outax
57-
from .keywordonly import kw_only_meth
5857
from .deprecated import deprecate_with_version
5958

6059
BLOCK_SIZE = 512
@@ -901,8 +900,7 @@ def _get_fileholders(file_map):
901900
return file_map['header'], file_map['image']
902901

903902
@classmethod
904-
@kw_only_meth(1)
905-
def from_file_map(klass, file_map, mmap=True, keep_file_open=None):
903+
def from_file_map(klass, file_map, *, mmap=True, keep_file_open=None):
906904
"""class method to create image from mapping
907905
specified in file_map
908906
"""

nibabel/freesurfer/mghformat.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
from ..spatialimages import HeaderDataError, SpatialImage
2222
from ..fileholders import FileHolder
2323
from ..arrayproxy import ArrayProxy, reshape_dataobj
24-
from ..keywordonly import kw_only_meth
2524
from ..openers import ImageOpener
2625
from ..batteryrunners import BatteryRunner, Report
2726
from ..wrapstruct import LabeledWrapStruct
@@ -537,8 +536,7 @@ def filespec_to_file_map(klass, filespec):
537536
return super(MGHImage, klass).filespec_to_file_map(filespec)
538537

539538
@classmethod
540-
@kw_only_meth(1)
541-
def from_file_map(klass, file_map, mmap=True, keep_file_open=None):
539+
def from_file_map(klass, file_map, *, mmap=True, keep_file_open=None):
542540
''' Class method to create image from mapping in ``file_map``
543541
544542
.. deprecated:: 2.4.1

nibabel/keywordonly.py

Lines changed: 0 additions & 28 deletions
This file was deleted.

nibabel/minc1.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
from .spatialimages import SpatialHeader, SpatialImage
1818
from .fileslice import canonical_slicers
1919

20-
from .keywordonly import kw_only_meth
2120
from .deprecated import deprecate_with_version
2221

2322
_dt_dict = {
@@ -340,8 +339,7 @@ class Minc1Image(SpatialImage):
340339
ImageArrayProxy = MincImageArrayProxy
341340

342341
@classmethod
343-
@kw_only_meth(1)
344-
def from_file_map(klass, file_map, mmap=True, keep_file_open=None):
342+
def from_file_map(klass, file_map, *, mmap=True, keep_file_open=None):
345343
# Note that mmap and keep_file_open are included for proper
346344
with file_map['image'].get_prepare_fileobj() as fobj:
347345
minc_file = Minc1File(netcdf_file(fobj))

nibabel/minc2.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
"""
2828
import numpy as np
2929

30-
from .keywordonly import kw_only_meth
3130
from ._h5py_compat import h5py
3231

3332
from .minc1 import Minc1File, MincHeader, Minc1Image, MincError
@@ -158,8 +157,7 @@ class Minc2Image(Minc1Image):
158157
header_class = Minc2Header
159158

160159
@classmethod
161-
@kw_only_meth(1)
162-
def from_file_map(klass, file_map, mmap=True, keep_file_open=None):
160+
def from_file_map(klass, file_map, *, mmap=True, keep_file_open=None):
163161
holder = file_map['image']
164162
if holder.filename is None:
165163
raise MincError('MINC2 needs filename for load')

0 commit comments

Comments
 (0)