STY: Apply ruff/pyupgrade rule UP031

UP031 Use format specifiers instead of percent format

Author: DimitriPapadopoulos

nibabel/cmdline/utils.py

@@ -65,7 +65,7 @@ def table2string(table, out=None):
     markup_strip = re.compile('^@([lrc]|w.*)')
     col_width = [max(len(markup_strip.sub('', x)) for x in column) for column in atable.T]
     string = ''
-    for i, table_ in enumerate(table):
+    for table_ in table:
         string_ = ''
         for j, item in enumerate(table_):
             item = str(item)
@@ -89,7 +89,7 @@ def table2string(table, out=None):
             else:
                 raise RuntimeError(f'Should not get here with align={align}')
 
-            string_ += '%%%ds%%s%%%ds ' % (nspacesl, nspacesr) % ('', item, '')
+            string_ += f'{" " * nspacesl}{item}{" " * nspacesr} '
         string += string_.rstrip() + '\n'
     out.write(string)
 

nibabel/volumeutils.py

@@ -338,11 +338,10 @@ def pretty_mapping(
     if getterfunc is None:
         getterfunc = getitem
     mxlen = max(len(str(name)) for name in mapping)
-    fmt = '%%-%ds  : %%s' % mxlen
     out = []
     for name in mapping:
         value = getterfunc(mapping, name)
-        out.append(fmt % (name, value))
+        out.append(f'{name:{mxlen}}  : {value}')
     return '\n'.join(out)
 
 

pyproject.toml

@@ -182,6 +182,7 @@ ignore = [
 [tool.ruff.lint.per-file-ignores]
 "__init__.py" = ["F401"]
 "doc/source/conf.py" = ["F401"]
+"nibabel/benchmarks/*.py" = ["UP031"]
 
 [tool.ruff.format]
 quote-style = "single"