Skip to content

Commit 7b5060e

Browse files
authored
Merge pull request #1380 from effigies/fix/mrs_type
FIX: Set MRS type to Nifti1Extension for backwards compatibility
2 parents 96c8320 + 56446e5 commit 7b5060e

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

Changelog

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,17 @@ Eric Larson (EL), Demian Wassermann, Stephan Gerhard and Ross Markello (RM).
2525

2626
References like "pr/298" refer to github pull request numbers.
2727

28+
5.3.2 (Wednesday 23 October 2024)
29+
=================================
30+
31+
Bug-fix release in the 5.3.x series.
32+
33+
Bug fixes
34+
---------
35+
* Restore MRS extension type to Nifti1Extension to maintain backwards compatibility.
36+
(pr/1380) (CM)
37+
38+
2839
5.3.1 (Tuesday 15 October 2024)
2940
===============================
3041

@@ -46,9 +57,9 @@ NiBabel 6.0 will drop support for Numpy 1.x.
4657

4758
New features
4859
------------
49-
* Update NIfTI extension protocol to include ``.content : bytes``, ``.text : str`` and ``.json : dict``
50-
properties for accessing extension contents. Exceptions will be raised on ``.text`` and ``.json`` if
51-
conversion fails. (pr/1336) (CM)
60+
* Update NIfTI extension protocol to include ``.content : bytes``, ``.text : str`` and
61+
``.json() : dict`` properties/methods for accessing extension contents.
62+
Exceptions will be raised on ``.text`` and ``.json()`` if conversion fails. (pr/1336) (CM)
5263

5364
Enhancements
5465
------------

nibabel/nifti1.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -675,7 +675,7 @@ def _mangle(self, dataset: DicomDataset) -> bytes:
675675
(38, 'eval', NiftiExtension),
676676
(40, 'matlab', NiftiExtension),
677677
(42, 'quantiphyse', NiftiExtension),
678-
(44, 'mrs', NiftiExtension[dict[str, ty.Any]]),
678+
(44, 'mrs', Nifti1Extension),
679679
),
680680
fields=('code', 'label', 'handler'),
681681
)

0 commit comments

Comments
 (0)