TEST: cmdline module to pytest

Author: Guidotti Roberto

nibabel/cmdline/tests/test_parrec2nii.py

@@ -9,7 +9,6 @@
 from nibabel.cmdline import parrec2nii
 
 from unittest.mock import Mock, MagicMock, patch
-from nose.tools import assert_true
 from numpy.testing import (assert_almost_equal, assert_array_equal)
 
 from nibabel.tests.test_parrec import EG_PAR, VARY_PAR
@@ -89,8 +88,8 @@ def test_parrec2nii_save_load_qform_code(*args):
         for fname in [EG_PAR, VARY_PAR]:
             parrec2nii.proc_file(fname, opts)
             outfname = join(pth, basename(fname)).replace('.PAR', '.nii')
-            assert_true(isfile(outfname))
+            assert isfile(outfname)
             img = nibabel.load(outfname)
             assert_almost_equal(img.affine, PAR_AFFINE, 4)
-            assert_array_equal(img.header['qform_code'], 1)
+            assert img.header['qform_code'] == 1
             assert_array_equal(img.header['sform_code'], 1)

nibabel/cmdline/tests/test_utils.py

@@ -5,9 +5,10 @@
 Test running scripts
 """
 
-from nose.tools import assert_equal
 from numpy.testing import assert_raises
 
+import pytest
+
 import nibabel as nib
 import numpy as np
 from nibabel.cmdline.utils import *
@@ -19,18 +20,18 @@
 
 
 def test_table2string():
-    assert_equal(table2string([["A", "B", "C", "D"], ["E", "F", "G", "H"]]), "A B C D\nE F G H\n")
-    assert_equal(table2string([["Let's", "Make", "Tests", "And"], ["Have", "Lots", "Of", "Fun"],
-                               ["With", "Python", "Guys", "!"]]), "Let's  Make  Tests And\n Have  Lots    Of  Fun"+
-                                                                  "\n With Python  Guys  !\n")
+    assert table2string([["A", "B", "C", "D"], ["E", "F", "G", "H"]]) == "A B C D\nE F G H\n"
+    assert table2string([["Let's", "Make", "Tests", "And"], ["Have", "Lots", "Of", "Fun"],
+                               ["With", "Python", "Guys", "!"]]) == "Let's  Make  Tests And\n Have  Lots    Of  Fun"+ \
+                                                                  "\n With Python  Guys  !\n"
 
 
 def test_ap():
-    assert_equal(ap([1, 2], "%2d"), " 1,  2")
-    assert_equal(ap([1, 2], "%3d"), "  1,   2")
-    assert_equal(ap([1, 2], "%-2d"), "1 , 2 ")
-    assert_equal(ap([1, 2], "%d", "+"), "1+2")
-    assert_equal(ap([1, 2, 3], "%d", "-"), "1-2-3")
+    assert ap([1, 2], "%2d") == " 1,  2"
+    assert ap([1, 2], "%3d") == "  1,   2"
+    assert ap([1, 2], "%-2d") == "1 , 2 "
+    assert ap([1, 2], "%d", "+") == "1+2"
+    assert ap([1, 2, 3], "%d", "-") == "1-2-3"
 
 
 def test_safe_get():
@@ -44,8 +45,8 @@ def get_test(self):
     test = TestObject()
     test.test = 2
 
-    assert_equal(safe_get(test, "test"), 2)
-    assert_equal(safe_get(test, "failtest"), "-")
+    assert safe_get(test, "test") == 2
+    assert safe_get(test, "failtest") == "-"
 
 
 def test_get_headers_diff():
@@ -107,14 +108,14 @@ def test_display_diff():
                                                        "                                                     " \
                                                        "\n"
 
-    assert_equal(display_diff(bogus_names, dict_values), expected_output)
+    assert display_diff(bogus_names, dict_values) == expected_output
 
 
 def test_get_data_diff():
     #  testing for identical files specifically as md5 may vary by computer
     test_names = [pjoin(data_path, f)
                   for f in ('standard.nii.gz', 'standard.nii.gz')]
-    assert_equal(get_data_hash_diff(test_names), [])
+    assert get_data_hash_diff(test_names) == []
 
     #  testing the maximum relative and absolute differences' different use cases
     test_array = np.arange(16).reshape(4, 4)
@@ -124,37 +125,37 @@ def test_get_data_diff():
     test_array_5 = np.arange(64).reshape(8, 8)
 
     # same shape, 2 files
-    assert_equal(get_data_diff([test_array, test_array_2]),
-                 OrderedDict([('DATA(diff 1:)', [None, OrderedDict([('abs', 1), ('rel', 2.0)])])]))
+    assert get_data_diff([test_array, test_array_2]) == \
+                 OrderedDict([('DATA(diff 1:)', [None, OrderedDict([('abs', 1), ('rel', 2.0)])])])
 
     # same shape, 3 files
-    assert_equal(get_data_diff([test_array, test_array_2, test_array_3]),
+    assert get_data_diff([test_array, test_array_2, test_array_3]) == \
                  OrderedDict([('DATA(diff 1:)', [None, OrderedDict([('abs', 1), ('rel', 2.0)]),
                                                  OrderedDict([('abs', 2), ('rel', 2.0)])]),
                               ('DATA(diff 2:)', [None, None,
-                                                 OrderedDict([('abs', 1), ('rel', 0.66666666666666663)])])]))
+                                                 OrderedDict([('abs', 1), ('rel', 0.66666666666666663)])])])
 
     # same shape, 2 files, modified maximum abs/rel
-    assert_equal(get_data_diff([test_array, test_array_2], max_abs=2, max_rel=2), OrderedDict())
+    assert get_data_diff([test_array, test_array_2], max_abs=2, max_rel=2) == OrderedDict()
 
     # different shape, 2 files
-    assert_equal(get_data_diff([test_array_2, test_array_4]),
-                 OrderedDict([('DATA(diff 1:)', [None, {'CMP': 'incompat'}])]))
+    assert get_data_diff([test_array_2, test_array_4]) == \
+                 OrderedDict([('DATA(diff 1:)', [None, {'CMP': 'incompat'}])])
 
     # different shape, 3 files
-    assert_equal(get_data_diff([test_array_4, test_array_5, test_array_2]),
+    assert get_data_diff([test_array_4, test_array_5, test_array_2]) == \
                  OrderedDict([('DATA(diff 1:)', [None, {'CMP': 'incompat'}, {'CMP': 'incompat'}]),
-                              ('DATA(diff 2:)', [None, None, {'CMP': 'incompat'}])]))
+                              ('DATA(diff 2:)', [None, None, {'CMP': 'incompat'}])])
 
     test_return = get_data_diff([test_array, test_array_2], dtype=np.float32)
-    assert_equal(type(test_return['DATA(diff 1:)'][1]['abs']), np.float32)
-    assert_equal(type(test_return['DATA(diff 1:)'][1]['rel']), np.float32)
+    assert type(test_return['DATA(diff 1:)'][1]['abs']) is np.float32
+    assert type(test_return['DATA(diff 1:)'][1]['rel']) is np.float32
 
     test_return_2 = get_data_diff([test_array, test_array_2, test_array_3])
-    assert_equal(type(test_return_2['DATA(diff 1:)'][1]['abs']), np.float64)
-    assert_equal(type(test_return_2['DATA(diff 1:)'][1]['rel']), np.float64)
-    assert_equal(type(test_return_2['DATA(diff 2:)'][2]['abs']), np.float64)
-    assert_equal(type(test_return_2['DATA(diff 2:)'][2]['rel']), np.float64)
+    assert type(test_return_2['DATA(diff 1:)'][1]['abs']) is np.float64
+    assert type(test_return_2['DATA(diff 1:)'][1]['rel']) is np.float64
+    assert type(test_return_2['DATA(diff 2:)'][2]['abs']) is np.float64
+    assert type(test_return_2['DATA(diff 2:)'][2]['rel']) is np.float64
 
 
 def test_main():
@@ -201,4 +202,4 @@ def test_main():
     test_names_2 = [pjoin(data_path, f) for f in ('standard.nii.gz', 'standard.nii.gz')]
 
     with assert_raises(SystemExit):
-        assert_equal(main(test_names_2, StringIO()), "These files are identical.")
+        assert main(test_names_2, StringIO()) == "These files are identical."