type: Address fresh complaints

Author: effigies

nibabel/deprecated.py

@@ -8,8 +8,7 @@
 from .deprecator import Deprecator
 from .pkg_info import cmp_pkg_version
 
-if ty.TYPE_CHECKING:
-    P = ty.ParamSpec('P')
+P = ty.ParamSpec('P')
 
 
 class ModuleProxy:
@@ -44,7 +43,7 @@ def __repr__(self) -> str:
         return f'<module proxy for {self._module_name}>'
 
 
-class FutureWarningMixin:
+class FutureWarningMixin(ty.Generic[P]):
     """Insert FutureWarning for object creation
 
     Examples

nibabel/nifti1.py

@@ -843,7 +843,7 @@ class Nifti1Header(SpmAnalyzeHeader):
     single_magic = b'n+1'
 
     # Quaternion threshold near 0, based on float32 precision
-    quaternion_threshold = np.finfo(np.float32).eps * 3
+    quaternion_threshold: np.floating = np.finfo(np.float32).eps * 3
 
     def __init__(self, binaryblock=None, endianness=None, check=True, extensions=()):
         """Initialize header from binary data block and extensions"""

nibabel/volumeutils.py

@@ -35,8 +35,8 @@
     DT = ty.TypeVar('DT', bound=np.generic)
 
 sys_is_le = sys.byteorder == 'little'
-native_code = '<' if sys_is_le else '>'
-swapped_code = '>' if sys_is_le else '<'
+native_code: ty.Literal['<', '>'] = '<' if sys_is_le else '>'
+swapped_code: ty.Literal['<', '>'] = '>' if sys_is_le else '<'
 
 _endian_codes = (  # numpy code, aliases
     ('<', 'little', 'l', 'le', 'L', 'LE'),