Merge pull request #1433 from effigies/sty/ruff

sty: Apply ruff fix for looped file.write

Author: effigies

nibabel/cmdline/parrec2nii.py

@@ -358,8 +358,7 @@ def proc_file(infile, opts):
             )
             with open(basefilename + '.bvals', 'w') as fid:
                 # np.savetxt could do this, but it's just a loop anyway
-                for val in bvals:
-                    fid.write(f'{val} ')
+                fid.writelines(f'{val} ' for val in bvals)
                 fid.write('\n')
         else:
             verbose('Writing .bvals and .bvecs files')
@@ -369,13 +368,11 @@ def proc_file(infile, opts):
             bvecs = apply_affine(bv_reorient, bvecs)
             with open(basefilename + '.bvals', 'w') as fid:
                 # np.savetxt could do this, but it's just a loop anyway
-                for val in bvals:
-                    fid.write(f'{val} ')
+                fid.writelines(f'{val} ' for val in bvals)
                 fid.write('\n')
             with open(basefilename + '.bvecs', 'w') as fid:
                 for row in bvecs.T:
-                    for val in row:
-                        fid.write(f'{val} ')
+                    fid.writelines(f'{val} ' for val in row)
                     fid.write('\n')
 
     # export data labels varying along the 4th dimensions if requested

nibabel/openers.py

@@ -21,7 +21,7 @@
 if ty.TYPE_CHECKING:
     from types import TracebackType
 
-    from _typeshed import WriteableBuffer
+    from _typeshed import ReadableBuffer, WriteableBuffer
 
     from ._typing import Self
 
@@ -231,6 +231,9 @@ def readinto(self, buffer: WriteableBuffer, /) -> int | None:
     def write(self, b: bytes, /) -> int | None:
         return self.fobj.write(b)
 
+    def writelines(self, lines: ty.Iterable[ReadableBuffer], /) -> None:
+        self.fobj.writelines(lines)
+
     def seek(self, pos: int, whence: int = 0, /) -> int:
         return self.fobj.seek(pos, whence)
 

nibabel/volumeutils.py

@@ -830,8 +830,7 @@ def write_zeros(fileobj: io.IOBase, count: int, block_size: int = 8194) -> None:
     nblocks = int(count // block_size)
     rem = count % block_size
     blk = b'\x00' * block_size
-    for bno in range(nblocks):
-        fileobj.write(blk)
+    fileobj.writelines(blk for bno in range(nblocks))
     fileobj.write(b'\x00' * rem)
 
 

pyproject.toml

@@ -164,7 +164,6 @@ ignore = [
     "RUF012", # TODO: enable
     "RUF015",
     "RUF017", # TODO: enable
-    "UP038",  # https://github.com/astral-sh/ruff/issues/7871
     # https://docs.astral.sh/ruff/formatter/#conflicting-lint-rules
     "W191",
     "E111",