Skip to content

parrec/minc1 don't subclass ArrayProxy #842

@rmarkello

Description

@rmarkello

While looking at #833 I noticed that neither PARRECArrayProxy nor MincImageArrayProxy subclass ArrayProxy despite there being considerable overlap in their functionality and structure. It seems like it would be reasonable to modify both classes such that they directly inherit from ArrayProxy to reduce duplication of some methods / doc-strings and make them a bit easier to keep in-line with ArrayProxy functionality. (Though I hope there's not a whole lot more changes coming to ArrayProxy in the near future.)

To be fair, based on my understanding neither parrec nor minc1 are widely used formats anymore, so this would be a relatively low-impact change for what could be a headache of a PR. Still, figured I'd bring it up for discussion and see what people thought. I'd be happy to try my hand at this in the coming weeks, if there's interest.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions