Skip to content

Commit 12e7608

Browse files
committed
tst: fixed all failing tests
1 parent 400050b commit 12e7608

File tree

6 files changed

+14
-307
lines changed

6 files changed

+14
-307
lines changed

nipype/interfaces/fsl/dti.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -542,7 +542,7 @@ class BEDPOSTX4(FSLCommand):
542542
>>> bedp = fsl.BEDPOSTX4(bpx_directory='subjdir', bvecs='bvecs', \
543543
bvals='bvals', dwi='diffusion.nii', mask='mask.nii', fibres=1)
544544
>>> bedp.cmdline
545-
'bedpostx subjdir -n 1'
545+
'bedpostx subjdir -n 1 --forcedir --logdir=logdir'
546546
547547
"""
548548

nipype/interfaces/fsl/tests/test_auto_BEDPOSTX4GPU.py

Lines changed: 0 additions & 68 deletions
This file was deleted.

nipype/interfaces/fsl/tests/test_auto_BEDPOSTX5GPU.py

Lines changed: 0 additions & 115 deletions
This file was deleted.

nipype/interfaces/fsl/tests/test_auto_BEDPOSTXGPU.py

Lines changed: 0 additions & 115 deletions
This file was deleted.

nipype/interfaces/fsl/tests/test_dti.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def test_oldbedpostx2():
7171
bpx2.inputs.jumps = 500
7272
bpx2.inputs.sampling = 20
7373
actualCmdline = sorted(bpx2.cmdline.split())
74-
cmd = 'bedpostx bedpostx -b 200 -n 2 -j 500 -s 20 -w 0.30'
74+
cmd = 'bedpostx bedpostx -b 200 -n 2 -j 500 -s 20 -w 0.30 --forcedir --logdir=logdir'
7575
desiredCmdline = sorted(cmd.split())
7676
yield assert_equal, actualCmdline, desiredCmdline
7777

nipype/workflows/dmri/fsl/dti.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ def merge_and_mean(name='mm'):
126126

127127
def bedpostx_parallel(name='bedpostx_parallel',
128128
compute_all_outputs=True,
129-
params={}):
129+
params=None):
130130
"""
131131
Does the same as :func:`.create_bedpostx_pipeline` by splitting
132132
the input dMRI in small ROIs that are better suited for parallel
@@ -161,19 +161,24 @@ def bedpostx_parallel(name='bedpostx_parallel',
161161
inputnode = pe.Node(niu.IdentityInterface(fields=['dwi', 'mask',
162162
'bvecs', 'bvals']), name='inputnode')
163163
slice_dwi = pe.Node(misc.SplitROIs(roi_size=(5, 5, 1)), name='slice_dwi')
164-
xfib_if = fsl.XFibres5(**params)
164+
if params is not None:
165+
xfib_if = fsl.XFibres5(**params)
166+
else:
167+
xfib_if = fsl.XFibres5()
165168
xfibres = pe.MapNode(xfib_if, name='xfibres',
166169
iterfield=['dwi', 'mask'])
167170

168171
mrg_dyads = pe.MapNode(misc.MergeROIs(), name='Merge_dyads',
169172
iterfield=['in_files'])
170173
mrg_fsamp = pe.MapNode(misc.MergeROIs(), name='Merge_mean_fsamples',
171174
iterfield=['in_files'])
172-
out_fields = ['dyads', 'mean_fsamples']
175+
out_fields = ['dyads', 'fsamples']
173176

174177
if compute_all_outputs:
175178
out_fields += ['dyads_disp', 'thsamples', 'phsamples',
176-
'fsamples', 'mean_thsamples', 'mean_phsamples']
179+
'mean_fsamples', 'mean_thsamples', 'mean_phsamples',
180+
'merged_fsamples', 'merged_thsamples',
181+
'merged_phsamples']
177182

178183
outputnode = pe.Node(niu.IdentityInterface(fields=out_fields),
179184
name='outputnode')
@@ -193,22 +198,22 @@ def bedpostx_parallel(name='bedpostx_parallel',
193198
(xfibres, mrg_fsamp, [(('mean_fsamples', transpose), 'in_files')]),
194199
(slice_dwi, mrg_fsamp, [('out_index', 'in_index')]),
195200
(mrg_dyads, outputnode, [('merged_file', 'dyads')]),
196-
(mrg_fsamp, outputnode, [('merged_file', 'mean_fsamples')])
201+
(mrg_fsamp, outputnode, [('merged_file', 'fsamples')])
197202
])
198203

199204
if compute_all_outputs:
200205
make_dyads = pe.MapNode(fsl.MakeDyadicVectors(), name="Make_dyads",
201206
iterfield=['theta_vol', 'phi_vol'])
202207

208+
wf.connect([(inputnode, make_dyads, [('mask', 'mask')])])
203209
mms = {}
204210
for k in ['thsamples', 'phsamples', 'fsamples']:
205211
mms[k] = merge_and_mean_parallel(k)
206212
wf.connect([
207-
(inputnode, make_dyads, [('mask', 'mask')]),
208213
(slice_dwi, mms[k], [('out_index', 'inputnode.in_index')]),
209214
(inputnode, mms[k], [('mask', 'inputnode.in_reference')]),
210215
(xfibres, mms[k], [(k, 'inputnode.in_files')]),
211-
(mms[k], outputnode, [('outputnode.merged', k),
216+
(mms[k], outputnode, [('outputnode.merged', 'merged_%s' % k),
212217
('outputnode.mean', 'mean_%s' % k)])
213218

214219
])

0 commit comments

Comments
 (0)