Skip to content

Commit 1357579

Browse files
committed
fix failing tests
1 parent 4b67fe0 commit 1357579

File tree

3 files changed

+7
-19
lines changed

3 files changed

+7
-19
lines changed

.coveragerc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
[run]
22
branch = True
3+
data_file = .coverage
34
source = nipype/
45
omit =
56
external/*

docker/files/run_examples.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ echo "log_to_file = true" >> ${HOME}/.nipype/nipype.cfg
1717
echo "log_directory = ${WORKDIR}/logs/example_${example_id}" >> ${HOME}/.nipype/nipype.cfg
1818

1919
# Set up coverage
20+
export COVERAGE_PROCESS_START=/src/nipype/.coveragerc
2021
sed -i -E "s/(source = ).*'/\1\/src\/nipype\/nipype/" /src/nipype/.coveragerc
22+
sed -i -E "s/(data_file = ).*'/\1\/\/work\/.coverage/" /src/nipype/.coveragerc
2123

2224
if [ "$2" == "MultiProc" ]; then
2325
echo "concurrency = multiprocessing" >> /src/nipype/.coveragerc
@@ -26,6 +28,6 @@ fi
2628
coverage run --rcfile=/src/nipype/.coveragerc /src/nipype/tools/run_examples.py $@
2729
exit_code=$?
2830

29-
coverage xml -o ${WORKDIR}/smoketest_${example_id}.xml || true
31+
coverage xml --rcfile=/src/nipype/.coveragerc -o ${WORKDIR}/smoketest_${example_id}.xml || true
3032

3133
exit $exit_code

nipype/utils/tests/test_cmd.py

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
from ...utils import nipype_cmd
1313

1414
PY3 = sys.version_info[0] >= 3
15-
PY2 = sys.version_info[0] < 2
1615

1716
@contextmanager
1817
def capture_sys_output():
@@ -35,20 +34,11 @@ def test_main_returns_2_on_empty(self):
3534

3635
exit_exception = cm.value
3736
assert exit_exception.code == 2
38-
39-
if PY2:
40-
assert stderr.getvalue() == \
41-
"""usage: nipype_cmd [-h] module interface
37+
assert stderr.getvalue() == \
38+
"""usage: nipype_cmd [-h] module interface
4239
nipype_cmd: error: too few arguments
43-
"""
44-
elif PY3:
45-
assert stderr.getvalue() == \
46-
"""usage: nipype_cmd [-h] module interface
47-
nipype_cmd: error: the following arguments are required: module, interface
4840
"""
4941

50-
assert stdout.getvalue() == ''
51-
5242
def test_main_returns_0_on_help(self):
5343
with pytest.raises(SystemExit) as cm:
5444
with capture_sys_output() as (stdout, stderr):
@@ -115,12 +105,7 @@ def test_run_4d_realign_without_arguments(self):
115105
in_file [in_file ...]
116106
tr"""
117107

118-
if PY3:
119-
error_message += """
120-
nipype_cmd nipype.interfaces.nipy FmriRealign4d: error: the following arguments are required: in_file, tr
121-
"""
122-
else:
123-
error_message += """
108+
error_message += """
124109
nipype_cmd nipype.interfaces.nipy FmriRealign4d: error: too few arguments
125110
"""
126111

0 commit comments

Comments
 (0)