Skip to content

Commit 54f7cf1

Browse files
authored
Merge pull request #1856 from mgxd/fix/ersh
fix: remove xor from EstimateResponseSH inputs
2 parents 08581d5 + 87eeb7e commit 54f7cf1

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

nipype/interfaces/dipy/reconstruction.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,11 +166,9 @@ class EstimateResponseSHInputSpec(DipyBaseInterfaceInputSpec):
166166
roi_radius = traits.Int(
167167
10, usedefault=True, desc=('ROI radius to be used in auto_response'))
168168
auto = traits.Bool(
169-
True, usedefault=True, xor=['recursive'],
170-
desc='use the auto_response estimator from dipy')
169+
xor=['recursive'], desc='use the auto_response estimator from dipy')
171170
recursive = traits.Bool(
172-
False, usedefault=True, xor=['auto'],
173-
desc='use the recursive response estimator from dipy')
171+
xor=['auto'], desc='use the recursive response estimator from dipy')
174172
response = File(
175173
'response.txt', usedefault=True, desc=('the output response file'))
176174
out_mask = File('wm_mask.nii.gz', usedefault=True, desc='computed wm mask')

nipype/interfaces/dipy/tests/test_auto_EstimateResponseSH.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44

55

66
def test_EstimateResponseSH_inputs():
7-
input_map = dict(auto=dict(usedefault=True,
8-
xor=['recursive'],
7+
input_map = dict(auto=dict(xor=['recursive'],
98
),
109
b0_thres=dict(usedefault=True,
1110
),
@@ -26,8 +25,7 @@ def test_EstimateResponseSH_inputs():
2625
out_mask=dict(usedefault=True,
2726
),
2827
out_prefix=dict(),
29-
recursive=dict(usedefault=True,
30-
xor=['auto'],
28+
recursive=dict(xor=['auto'],
3129
),
3230
response=dict(usedefault=True,
3331
),

0 commit comments

Comments
 (0)