Skip to content

Commit 6949323

Browse files
committed
simplify fname_presuffix adding test
1 parent 8629376 commit 6949323

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

nipype/utils/filemanip.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,13 +175,17 @@ def fname_presuffix(fname, prefix='', suffix='', newpath=None, use_ext=True):
175175
>>> fname_presuffix(fname,'pre','post','/tmp')
176176
'/tmp/prefoopost.nii.gz'
177177
178+
>>> from nipype.interfaces.base import Undefined
179+
>>> fname_presuffix(fname, 'pre', 'post', Undefined) == fname_presuffix(fname, 'pre', 'post')
180+
True
181+
178182
"""
179183
pth, fname, ext = split_filename(fname)
180184
if not use_ext:
181185
ext = ''
182186

183-
# Avoid cyclic references importing isdefined
184-
if newpath and ('%s' % newpath) != '<undefined>':
187+
# No need for isdefined: bool(Undefined) evaluates to False
188+
if newpath:
185189
pth = os.path.abspath(newpath)
186190
return os.path.join(pth, prefix + fname + suffix + ext)
187191

0 commit comments

Comments
 (0)