Skip to content

Commit 725b738

Browse files
author
Shoshana Berleant
authored
Merge pull request #1520 from shoshber/contributing
DOC: (m) CHANGES policy, easier make check
2 parents 15a2bee + 1436a04 commit 725b738

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,8 @@
1111
- bugfixes should include regression tests
1212
- new behavior should at least get minimal exercise
1313
* Use a descriptive prefix for your PR: ENH (enhancement), FIX, TST, DOC, STY, REF (refactor), WIP (Work in progress)
14-
* After submitting the PR, include an update to the CHANGES file: prefix: description (URL of pull request)
15-
* `make specs`
16-
* do: `make check-before-commit` before submitting the PR. This will require you to either install or be in developer mode with: `python setup.py install/develop`.
14+
* The person who accepts/merges your PR will include an update to the CHANGES file: prefix: description (URL of pull request)
15+
* Run `make check-before-commit` before submitting the PR.
1716
* In general, do not catch exceptions without good reason.
1817
* catching non-fatal exceptions.
1918
Log the exception as a warning.

Makefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@ html:
7070
make -C doc clean htmlonly
7171

7272
specs:
73+
@echo "Setting up developer mode"
74+
python setup.py develop
7375
@echo "Checking specs and autogenerating spec tests"
7476
python tools/checkspecs.py
7577

0 commit comments

Comments
 (0)