Skip to content

Commit 8331445

Browse files
committed
fix: more py36 fixes and doc updates
1 parent 40d1572 commit 8331445

File tree

2 files changed

+20
-30
lines changed

2 files changed

+20
-30
lines changed

.circle/tests.sh

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,24 +17,24 @@ fi
1717
# They may need to be rebalanced in the future.
1818
case ${CIRCLE_NODE_INDEX} in
1919
0)
20-
docker run --rm=false -it -e FSL_COURSE_DATA="/data/examples/nipype-fsl_course_data" -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py35 /usr/bin/run_pytests.sh && \
20+
docker run --rm=false -it -e FSL_COURSE_DATA="/data/examples/nipype-fsl_course_data" -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py36 /usr/bin/run_pytests.sh && \
2121
docker run --rm=false -it -e FSL_COURSE_DATA="/data/examples/nipype-fsl_course_data" -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py27 /usr/bin/run_pytests.sh && \
22-
docker run --rm=false -it -v $WORKDIR:/work -w /src/nipype/doc nipype/nipype:py35 /usr/bin/run_builddocs.sh && \
23-
docker run --rm=false -it -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py35 /usr/bin/run_examples.sh test_spm Linear /data/examples/ workflow3d && \
24-
docker run --rm=false -it -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py35 /usr/bin/run_examples.sh test_spm Linear /data/examples/ workflow4d
22+
docker run --rm=false -it -v $WORKDIR:/work -w /src/nipype/doc nipype/nipype:py36 /usr/bin/run_builddocs.sh && \
23+
docker run --rm=false -it -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py36 /usr/bin/run_examples.sh test_spm Linear /data/examples/ workflow3d && \
24+
docker run --rm=false -it -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py36 /usr/bin/run_examples.sh test_spm Linear /data/examples/ workflow4d
2525
;;
2626
1)
27-
docker run --rm=false -it -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py35 /usr/bin/run_examples.sh fmri_spm_dartel Linear /data/examples/ level1 && \
28-
docker run --rm=false -it -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py35 /usr/bin/run_examples.sh fmri_spm_dartel Linear /data/examples/ l2pipeline
27+
docker run --rm=false -it -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py36 /usr/bin/run_examples.sh fmri_spm_dartel Linear /data/examples/ level1 && \
28+
docker run --rm=false -it -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py36 /usr/bin/run_examples.sh fmri_spm_dartel Linear /data/examples/ l2pipeline
2929
;;
3030
2)
3131
docker run --rm=false -it -e NIPYPE_NUMBER_OF_CPUS=4 -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py27 /usr/bin/run_examples.sh fmri_spm_nested MultiProc /data/examples/ level1 && \
32-
docker run --rm=false -it -e NIPYPE_NUMBER_OF_CPUS=4 -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py35 /usr/bin/run_examples.sh fmri_spm_nested MultiProc /data/examples/ l2pipeline
32+
docker run --rm=false -it -e NIPYPE_NUMBER_OF_CPUS=4 -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py36 /usr/bin/run_examples.sh fmri_spm_nested MultiProc /data/examples/ l2pipeline
3333
;;
3434
3)
35-
docker run --rm=false -it -e NIPYPE_NUMBER_OF_CPUS=4 -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py35 /usr/bin/run_examples.sh fmri_spm_nested MultiProc /data/examples/ level1 && \
36-
docker run --rm=false -it -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py35 /usr/bin/run_examples.sh fmri_fsl_feeds Linear /data/examples/ l1pipeline && \
37-
docker run --rm=false -it -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py35 /usr/bin/run_examples.sh fmri_fsl_reuse Linear /data/examples/ level1_workflow
35+
docker run --rm=false -it -e NIPYPE_NUMBER_OF_CPUS=4 -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py36 /usr/bin/run_examples.sh fmri_spm_nested MultiProc /data/examples/ level1 && \
36+
docker run --rm=false -it -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py36 /usr/bin/run_examples.sh fmri_fsl_feeds Linear /data/examples/ l1pipeline && \
37+
docker run --rm=false -it -v $HOME/examples:/data/examples:ro -v $WORKDIR:/work -w /work nipype/nipype:py36 /usr/bin/run_examples.sh fmri_fsl_reuse Linear /data/examples/ level1_workflow
3838
;;
3939
esac
4040

doc/devel/testing_nipype.rst

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -109,16 +109,17 @@ Testing Nipype using Docker
109109

110110
As of :code:`nipype-0.13`, Nipype is tested inside Docker containers. First, install the
111111
`Docker Engine <https://docs.docker.com/engine/installation/>`_.
112-
Nipype has one base docker image called nipype/nipype, and several additional test images
112+
Nipype has one base docker image called nipype/base:latest, and several additional test images
113113
for various Python versions.
114114

115-
The base nipype/nipype image is built as follows::
115+
The base nipype image is built as follows::
116116

117117
cd path/to/nipype/
118-
docker build -t nipype/nipype .
118+
docker build -t nipype/base:latest -f docker/base.Dockerfile .
119+
120+
This base image contains several useful tools (FreeSurfer, AFNI, FSL, ANTs, etc.),
121+
but not nipype.
119122

120-
This base image contains several useful tools (FreeSurfer, AFNI, FSL, ANTs, etc.) and
121-
a nipype installation, all in Python 3.5.
122123
It is possible to fetch a built image from the latest master branch of nipype
123124
using::
124125

@@ -128,26 +129,15 @@ using::
128129
The docker run command will then open the container and offer a bash shell for the
129130
developer.
130131

131-
The additional test images have several test scripts installed. For instance,
132-
to build and run all tests on Python 2.7::
133-
134-
cd path/to/nipype/
135-
docker build -f docker/Dockerfile_py27 -t nipype/nipype_test:py27 .
136-
docker run -it --rm -e FSL_COURSE_DATA="/root/examples/nipype-fsl_course_data" \
137-
-v ~/examples:/root/examples:ro \
138-
-v ~/scratch:/scratch \
139-
-w /root/src/nipype \
140-
nipype/nipype_test:py27 /usr/bin/run_pytests.sh
141-
142-
For running nipype in Python 3.5::
132+
For building a continer for running nipype in Python 3.6::
143133

144134
cd path/to/nipype/
145-
docker build -f docker/Dockerfile_py35 -t nipype/nipype_test:py35 .
135+
docker build -f Dockerfile -t nipype/nipype_test:py36 .
146136
docker run -it --rm -e FSL_COURSE_DATA="/root/examples/nipype-fsl_course_data" \
147137
-v ~/examples:/root/examples:ro \
148138
-v ~/scratch:/scratch \
149139
-w /root/src/nipype \
150-
nipype/nipype_test:py35 /usr/bin/run_pytests.sh
140+
nipype/nipype_test:py36 /usr/bin/run_pytests.sh
151141

152-
The last two examples assume that the example data is downladed into ~/examples and
142+
The last examples assume that the example data is downladed into ~/examples and
153143
the ~/scratch folder will be created if it does not exist previously.

0 commit comments

Comments
 (0)