Skip to content

Commit 89b530a

Browse files
author
Shoshana Berleant
committed
factor out deleting temp files
1 parent 61da367 commit 89b530a

File tree

3 files changed

+26
-19
lines changed

3 files changed

+26
-19
lines changed

nipype/algorithms/tests/test_compcor.py

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,21 @@
1414
class TestCompCor(unittest.TestCase):
1515
''' Note: Tests currently do a poor job of testing functionality '''
1616

17-
functionalnii = 'compcorfunc.nii'
18-
masknii = 'compcormask.nii'
19-
components_file = None
17+
filenames = {'functionalnii': 'compcorfunc.nii',
18+
'masknii': 'compcormask.nii',
19+
'components_file': None}
2020

2121
def setUp(self):
2222
# setup
2323
noise = np.fromfunction(self.fake_noise_fun, self.fake_data.shape)
2424
self.realigned_file = utils.save_toy_nii(self.fake_data + noise,
25-
self.functionalnii)
25+
self.filenames['functionalnii'])
2626

2727
def test_compcor(self):
2828
mask = np.ones(self.fake_data.shape[:3])
2929
mask[0,0,0] = 0
3030
mask[0,0,1] = 0
31-
mask_file = utils.save_toy_nii(mask, self.masknii)
31+
mask_file = utils.save_toy_nii(mask, self.filenames['masknii'])
3232

3333
ccresult = self.run_cc(CompCor(realigned_file=self.realigned_file,
3434
mask_file=mask_file))
@@ -58,13 +58,7 @@ def run_cc(self, ccinterface):
5858
return ccresult
5959

6060
def tearDown(self):
61-
# remove temporary nifti files
62-
try:
63-
os.remove(self.functionalnii)
64-
os.remove(self.components_file)
65-
os.remove(self.masknii)
66-
except (OSError, TypeError) as e:
67-
print(e)
61+
utils.remove_nii(self.filenames.values())
6862

6963
def fake_noise_fun(self, i, j, l, m):
7064
return m*i + l - j

nipype/algorithms/tests/test_tsnr.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,20 @@ class TestTSNR(unittest.TestCase):
1616
in_file = InputMultiPath(File(exists=True), mandatory=True,
1717
regress_poly = traits.Range(low=1, desc='Remove polynomials')
1818
'''
19-
in_file_name = 'tsnrinfile.nii'
19+
20+
filenames = {
21+
'in_file': 'tsnrinfile.nii',
22+
23+
# default output file names
24+
'detrended_file': '/home/ubuntu/nipype/detrend.nii.gz',
25+
'mean_file': '/home/ubuntu/nipype/mean.nii.gz',
26+
'stddev_file': '/home/ubuntu/nipype/stdev.nii.gz',
27+
'tsnr_file': '/home/ubuntu/nipype/tsnr.nii.gz'
28+
}
2029

2130
def setUp(self):
2231
# setup
23-
utils.save_toy_nii(self.fake_data, self.in_file_name)
32+
utils.save_toy_nii(self.fake_data, self.filenames['in_file'])
2433

2534
def test_tsnr(self):
2635
# setup
@@ -30,11 +39,7 @@ def test_tsnr(self):
3039
# cleanup
3140

3241
def tearDown(self):
33-
# remove temporary nifti files
34-
try:
35-
os.remove(self.in_file_name)
36-
except (OSError, TypeError) as e:
37-
print(e)
42+
utils.remove_nii(self.filenames.values())
3843

3944
fake_data = np.array([[[[2, 4, 3, 9, 1],
4045
[3, 6, 4, 7, 4]],

nipype/testing/utils.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,3 +106,11 @@ def save_toy_nii(ndarray, filename):
106106
toy = nb.Nifti1Image(ndarray, np.eye(4))
107107
nb.nifti1.save(toy, filename)
108108
return filename
109+
110+
def remove_nii(filenames):
111+
''' remove temporary nifti files'''
112+
for filename in filenames:
113+
try:
114+
os.remove(filename)
115+
except (OSError, TypeError) as e:
116+
print(e)

0 commit comments

Comments
 (0)