Skip to content

Commit a15f1d7

Browse files
committed
update variable names
1 parent 9098697 commit a15f1d7

File tree

2 files changed

+42
-47
lines changed

2 files changed

+42
-47
lines changed

nipype/interfaces/fsl/epi.py

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -664,8 +664,6 @@ class EddyInputSpec(FSLCommandInputSpec):
664664
desc="Do NOT perform a post-eddy alignment of "
665665
"shells")
666666
fwhm = traits.Float(
667-
default_value=0.0,
668-
usedefault=True,
669667
desc=('FWHM for conditioning filter when estimating '
670668
'the parameters'),
671669
argstr='--fwhm=%s')
@@ -722,32 +720,32 @@ class EddyInputSpec(FSLCommandInputSpec):
722720
argstr='--mb_offs=%d',
723721
desc=('Multi-band offset (-1 if bottom slice removed, 1 if '
724722
'top slice removed'),
725-
requires=['mb'],
723+
requires=['multiband_factor'],
726724
min_ver='5.0.10')
727725

728726
mporder = traits.Int(
729727
argstr='--mporder=%s',
730728
desc='Order of slice-to-vol movement model',
731729
requires=['use_cuda'],
732730
min_ver='5.0.11')
733-
slice2vol_iterations = traits.Int(
734-
argstr='--s2v_niter=%s',
731+
slice2vol_niter = traits.Int(
732+
argstr='--s2v_niter=%d',
735733
desc='Number of iterations for slice-to-vol',
736734
requires=['mporder'],
737735
min_ver='5.0.11')
738-
s2v_lambda = traits.Int(
739-
agstr='--s2v_lambda',
736+
slice2vol_lambda = traits.Int(
737+
argstr='--s2v_lambda=%d',
740738
desc='Regularisation weight for slice-to-vol movement (reasonable range 1-10)',
741739
requires=['mporder'],
742740
min_ver='5.0.11')
743-
s2v_interp = traits.Enum(
741+
slice2vol_interp = traits.Enum(
744742
'trilinear',
745743
'spline',
746744
argstr='--s2v_interp=%s',
747745
desc='Slice-to-vol interpolation model for estimation step',
748746
requires=['mporder'],
749747
min_ver='5.0.11')
750-
slspec = traits.File(
748+
slice_order = traits.File(
751749
exists=True,
752750
argstr='--slspec=%s',
753751
desc='Name of text file completely specifying slice/group acquisition',
@@ -759,7 +757,7 @@ class EddyInputSpec(FSLCommandInputSpec):
759757
argstr='--json=%s',
760758
desc='Name of .json text file with information about slice timing',
761759
requires=['mporder'],
762-
xor=['slspec'],
760+
xor=['slice_order'],
763761
min_ver='6.0.1')
764762

765763
estimate_move_by_susceptibility = traits.Bool(
@@ -898,7 +896,7 @@ class Eddy(FSLCommand):
898896
>>> eddy.inputs.in_bval = 'bvals.scheme'
899897
>>> eddy.inputs.use_cuda = True
900898
>>> eddy.cmdline # doctest: +ELLIPSIS
901-
'eddy_cuda --flm=quadratic --ff=10.0 --fwhm=0.0 \
899+
'eddy_cuda --flm=quadratic --ff=10.0 \
902900
--acqp=epi_acqp.txt --bvals=bvals.scheme --bvecs=bvecs.scheme \
903901
--imain=epi.nii --index=epi_index.txt --mask=epi_mask.nii \
904902
--interp=spline --resamp=jac --niter=5 --nvoxhp=1000 \
@@ -907,7 +905,7 @@ class Eddy(FSLCommand):
907905
Running eddy on a CPU using OpenMP:
908906
>>> eddy.inputs.use_cuda = False
909907
>>> eddy.cmdline # doctest: +ELLIPSIS
910-
'eddy_openmp --flm=quadratic --ff=10.0 --fwhm=0.0 \
908+
'eddy_openmp --flm=quadratic --ff=10.0 \
911909
--acqp=epi_acqp.txt --bvals=bvals.scheme --bvecs=bvecs.scheme \
912910
--imain=epi.nii --index=epi_index.txt --mask=epi_mask.nii \
913911
--interp=spline --resamp=jac --niter=5 --nvoxhp=1000 \
@@ -916,17 +914,17 @@ class Eddy(FSLCommand):
916914
Running eddy with slice-to-volume motion correction:
917915
>>> eddy.inputs.use_cuda = True
918916
>>> eddy.inputs.mporder = 6
919-
>>> eddy.inputs.s2v_niter = 5
920-
>>> eddy.inputs.s2v_lambda = 1
921-
>>> eddy.inputs.s2v_interp = 'trilinear'
922-
>>> eddy.inputs.slspec = 'epi_slspec.txt'
917+
>>> eddy.inputs.slice2vol_niter = 5
918+
>>> eddy.inputs.slice2vol_lambda = 1
919+
>>> eddy.inputs.slice2vol_interp = 'trilinear'
920+
>>> eddy.inputs.slice_order = 'epi_slspec.txt'
923921
>>> eddy.cmdline # doctest: +ELLIPSIS
924-
'eddy_cuda --flm=quadratic --ff=10.0 --fwhm=0.0 \
922+
'eddy_cuda --flm=quadratic --ff=10.0 \
925923
--acqp=epi_acqp.txt --bvals=bvals.scheme --bvecs=bvecs.scheme \
926924
--imain=epi.nii --index=epi_index.txt --mask=epi_mask.nii \
927925
--interp=spline --resamp=jac --mporder=6 --niter=5 --nvoxhp=1000 \
928-
--out=.../eddy_corrected --s2v_interp=trilinear --s2v_niter=5 \
929-
--slm=none --slspec=epi_slspec.txt'
926+
--out=.../eddy_corrected --s2v_interp=trilinear --s2v_lambda=1 \
927+
--s2v_niter=5 --slspec=epi_slspec.txt --slm=none'
930928
>>> res = eddy.run() # doctest: +SKIP
931929
932930
"""

nipype/interfaces/fsl/tests/test_auto_Eddy.py

Lines changed: 25 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,7 @@ def test_Eddy_inputs():
3636
argstr='--ff=%s',
3737
usedefault=True,
3838
),
39-
fwhm=dict(
40-
argstr='--fwhm=%s',
41-
usedefault=True,
42-
),
39+
fwhm=dict(argstr='--fwhm=%s', ),
4340
in_acqp=dict(
4441
argstr='--acqp=%s',
4542
extensions=None,
@@ -92,16 +89,7 @@ def test_Eddy_inputs():
9289
argstr='--json=%s',
9390
min_ver='6.0.1',
9491
requires=['mporder'],
95-
xor=['slspec'],
96-
),
97-
mb=dict(
98-
argstr='--mb=%s',
99-
min_ver='5.0.10',
100-
),
101-
mb_offs=dict(
102-
argstr='--mb_offs=%s',
103-
min_ver='5.0.10',
104-
requires=['mb'],
92+
xor=['slice_order'],
10593
),
10694
mbs_ksp=dict(
10795
argstr='--mbs_ksp=%smm',
@@ -127,6 +115,15 @@ def test_Eddy_inputs():
127115
min_ver='5.0.11',
128116
requires=['use_cuda'],
129117
),
118+
multiband_factor=dict(
119+
argstr='--mb=%s',
120+
min_ver='5.0.10',
121+
),
122+
multiband_offset=dict(
123+
argstr='--mb_offs=%d',
124+
min_ver='5.0.10',
125+
requires=['multiband_factor'],
126+
),
130127
niter=dict(
131128
argstr='--niter=%s',
132129
usedefault=True,
@@ -174,35 +171,35 @@ def test_Eddy_inputs():
174171
argstr='--residuals',
175172
min_ver='5.0.10',
176173
),
177-
s2v_interp=dict(
174+
session=dict(
175+
argstr='--session=%s',
176+
extensions=None,
177+
),
178+
slice2vol_interp=dict(
178179
argstr='--s2v_interp=%s',
179180
min_ver='5.0.11',
180181
requires=['mporder'],
181182
),
182-
s2v_lambda=dict(
183-
agstr='--s2v_lambda',
183+
slice2vol_lambda=dict(
184+
argstr='--s2v_lambda=%d',
184185
min_ver='5.0.11',
185186
requires=['mporder'],
186187
),
187-
s2v_niter=dict(
188-
argstr='--s2v_niter=%s',
188+
slice2vol_niter=dict(
189+
argstr='--s2v_niter=%d',
189190
min_ver='5.0.11',
190191
requires=['mporder'],
191192
),
192-
session=dict(
193-
argstr='--session=%s',
194-
extensions=None,
195-
),
196-
slm=dict(
197-
argstr='--slm=%s',
198-
usedefault=True,
199-
),
200-
slspec=dict(
193+
slice_order=dict(
201194
argstr='--slspec=%s',
202195
min_ver='5.0.11',
203196
requires=['mporder'],
204197
xor=['json'],
205198
),
199+
slm=dict(
200+
argstr='--slm=%s',
201+
usedefault=True,
202+
),
206203
use_cuda=dict(),
207204
)
208205
inputs = Eddy.input_spec()

0 commit comments

Comments
 (0)