fix: set default to false, str2bool, join traceback list

Author: mgxd

nipype/pipeline/plugins/base.py

@@ -68,14 +68,14 @@ def report_crash(node, traceback=None, hostname=None):
     if not os.path.exists(crashdir):
         os.makedirs(crashdir)
     crashfile = os.path.join(crashdir, crashfile)
-    if node.config['execution']['text_crashfiles']:
+    if str2bool(node.config['execution']['text_crashfiles']):
         crashfile += '.txt'
     else:
         crashfile += '.pklz'
     logger.info('Saving crash info to %s' % crashfile)
     logger.info(''.join(traceback))
-    if node.config['execution']['text_crashfiles']:
-        crash_to_txt(crashfile, dict(node=node, traceback=traceback))
+    if str2bool(node.config['execution']['text_crashfiles']):
+        crash2txt(crashfile, dict(node=node, traceback=traceback))
     else:
         savepkl(crashfile, dict(node=node, traceback=traceback))
     return crashfile

nipype/utils/config.py

@@ -55,7 +55,7 @@
 remove_unnecessary_outputs = true
 try_hard_link_datasink = true
 single_thread_matlab = true
-text_crashfiles = true
+text_crashfiles = false
 stop_on_first_crash = false
 stop_on_first_rerun = false
 use_relative_paths = false

nipype/utils/filemanip.py

@@ -540,7 +540,7 @@ def crash2txt(filename, record):
             fp.write('Working directory: {}\n'.format(node.output_dir()))
             fp.write('\n')
             fp.write('Node inputs:\n{}\n'.format(node.inputs))
-        fp.write(record['traceback'])
+        fp.write(''.join(record['traceback']))
 
 
 def savepkl(filename, record):