make sure the OSError when cwd is deleted by other process is handled gracefully

Author: oesteban

nipype/pipeline/engine/nodes.py

@@ -428,7 +428,14 @@ def run(self, updatehash=False):
         savepkl(op.join(outdir, '_inputs.pklz'),
                 self.inputs.get_traitsfree())
 
-        cwd = os.getcwd()
+        try:
+            cwd = os.getcwd()
+        except OSError:
+            # Changing back to cwd is probably not necessary
+            # but this makes sure there's somewhere to change to.
+            cwd = os.path.split(outdir)[0]
+            logger.debug('Current folder does not exist, changing to "%s" instead.', cwd)
+
         os.chdir(outdir)
         try:
             result = self._run_interface(execute=True)
@@ -1009,8 +1016,8 @@ def inputs(self):
 
     @property
     def outputs(self):
-        if self._interface._outputs():
-            return Bunch(self._interface._outputs().get())
+        if self.interface._outputs():
+            return Bunch(self.interface._outputs().get())
 
     def _make_nodes(self, cwd=None):
         if cwd is None:
@@ -1030,7 +1037,7 @@ def _make_nodes(self, cwd=None):
                         base_dir=op.join(cwd, 'mapflow'),
                         name=nodename)
             node.plugin_args = self.plugin_args
-            node._interface.inputs.trait_set(
+            node.interface.inputs.trait_set(
                 **deepcopy(self._interface.inputs.get()))
             node.interface.resource_monitor = self._interface.resource_monitor
             for field in self.iterfield:
@@ -1177,6 +1184,7 @@ def _run_interface(self, execute=True, updatehash=False):
                 if path.split(op.sep)[-1] not in nodenames:
                     dirs2remove.append(path)
         for path in dirs2remove:
+            logger.debug('[MapNode] Removing folder "%s".' , path)
             shutil.rmtree(path)
 
         return result

nipype/pipeline/plugins/base.py

@@ -408,7 +408,7 @@ def _remove_node_dirs(self):
                     continue
                 if self.proc_done[idx] and (not self.proc_pending[idx]):
                     self.refidx[idx, idx] = -1
-                    outdir = self.procs[idx]._output_directory()
+                    outdir = self.procs[idx].output_dir()
                     logger.info(('[node dependencies finished] '
                                  'removing node: %s from directory %s') %
                                 (self.procs[idx]._id, outdir))