[ENH] Fix paths for coverage in circleci

To understand the test files, the xml files should be placed in
a subfolder of ${CIRCLE_TEST_REPORTS} (see
https://circleci.com/docs/1.0/test-metadata/#metadata-collection-in-custom-test-steps)

Author: oesteban

.circle/codecov.sh

@@ -9,17 +9,15 @@ set -e         # Exit immediately if a command exits with a non-zero status.
 set -u         # Treat unset variables as an error when substituting.
 set -x         # Print command traces before executing command.
 
-mkdir -p ${CIRCLE_TEST_REPORTS}/
-for report in $( ls ~/scratch/*.xml ); do
-    rname=$( basename $report )
-    cp ${report} ${CIRCLE_TEST_REPORTS}/${rname:: -4}_${CIRCLE_NODE_INDEX}.xml
-done
+mkdir -p ${CIRCLE_TEST_REPORTS}/unittests ${CIRCLE_TEST_REPORTS}/smoketest
+cp ${SCRATCH}/coverage*.xml ${CIRCLE_TEST_REPORTS}/unittests/
+cp ${SCRATCH}/smoketests*.xml ${CIRCLE_TEST_REPORTS}/smoketest/
 
 # Send coverage data to codecov.io
 curl -so codecov.io https://codecov.io/bash
 chmod 755 codecov.io
 
-find "${CIRCLE_TEST_REPORTS}/" -name 'coverage*.xml' -print0 | \
+find "${CIRCLE_TEST_REPORTS}/unittests" -name '*.xml' -print0 | \
   xargs -0 -I file ./codecov.io -f file -t "${CODECOV_TOKEN}" -F unittests
-find "${CIRCLE_TEST_REPORTS}/" -name 'smoketests*.xml' -print0 | \
+find "${CIRCLE_TEST_REPORTS}/smoketest" -name '*.xml' -print0 | \
   xargs -0 -I file ./codecov.io -f file -t "${CODECOV_TOKEN}" -F smoketests