fix: version check and tests

Author: satra

nipype/interfaces/base.py

@@ -28,7 +28,7 @@
 from ..utils.filemanip import (md5, hash_infile, FileNotFoundError,
                                hash_timestamp)
 from ..utils.misc import is_container, trim, str2bool
-from .. import config, logging
+from .. import config, logging, LooseVersion
 
 iflogger = logging.getLogger('interface')
 
@@ -795,23 +795,23 @@ def _check_mandatory_inputs(self):
     def _check_input_version_requirements(self):
         """ Raises an exception on version mismatch
         """
-        version = str(self.version)
+        version = LooseVersion(str(self.version))
         if not version:
             return
         # check minimum version
         names = self.inputs.trait_names(**dict(min_ver=lambda t: t is not None))
         for name in names:
             if not isdefined(getattr(self.inputs, name)):
                 continue
-            min_ver = str(self.inputs.traits()[name].min_ver)
+            min_ver = LooseVersion(str(self.inputs.traits()[name].min_ver))
             if min_ver > version:
                 raise Exception('Input %s (%s) (version %s < required %s)' %
                               (name, self.__class__.__name__, version, min_ver))
         names = self.inputs.trait_names(**dict(max_ver=lambda t: t is not None))
         for name in names:
             if not isdefined(getattr(self.inputs, name)):
                 continue
-            max_ver = str(self.inputs.traits()[name].max_ver)
+            max_ver = LooseVersion(str(self.inputs.traits()[name].max_ver))
             if max_ver < version:
                 raise Exception('Input %s (%s) (version %s > required %s)' %
                               (name, self.__class__.__name__, version, max_ver))

nipype/interfaces/tests/test_base.py

@@ -254,13 +254,27 @@ class DerivedInterface1(nib.BaseInterface):
         input_spec = InputSpec
         _version = 0.8
     obj = DerivedInterface1()
+    obj.inputs.foo = 1
     yield assert_raises, Exception, obj._check_input_version_requirements
+    class InputSpec(nib.TraitedSpec):
+        foo = nib.traits.Int(desc='a random int', min_ver=0.9)
+    class DerivedInterface1(nib.BaseInterface):
+        input_spec = InputSpec
+        _version = 0.10
+    obj = DerivedInterface1()
+    not_raised = True
+    try:
+        obj._check_input_version_requirements()
+    except:
+        not_raised = False
+    yield assert_true, not_raised
     class InputSpec(nib.TraitedSpec):
         foo = nib.traits.Int(desc='a random int', min_ver=0.9)
     class DerivedInterface1(nib.BaseInterface):
         input_spec = InputSpec
         _version = 0.9
     obj = DerivedInterface1()
+    obj.inputs.foo = 1
     not_raised = True
     try:
         obj._check_input_version_requirements()
@@ -273,13 +287,15 @@ class DerivedInterface2(nib.BaseInterface):
         input_spec = InputSpec
         _version = 0.8
     obj = DerivedInterface2()
+    obj.inputs.foo = 1
     yield assert_raises, Exception, obj._check_input_version_requirements
     class InputSpec(nib.TraitedSpec):
         foo = nib.traits.Int(desc='a random int', max_ver=0.9)
     class DerivedInterface1(nib.BaseInterface):
         input_spec = InputSpec
         _version = 0.9
     obj = DerivedInterface1()
+    obj.inputs.foo = 1
     not_raised = True
     try:
         obj._check_input_version_requirements()