Skip to content

Commit bc85f3e

Browse files
Use set for newnodes to make adding faster
- Do not need to loop over entries - Faster O(1) __contains__
1 parent 1c789ad commit bc85f3e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

nipype/pipeline/engine/workflows.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ def connect(self, *args, **kwargs):
144144
self.disconnect(connection_list)
145145
return
146146

147-
newnodes = []
147+
newnodes = set()
148148
for srcnode, destnode, _ in connection_list:
149149
if self in [srcnode, destnode]:
150150
msg = (
@@ -154,9 +154,9 @@ def connect(self, *args, **kwargs):
154154

155155
raise IOError(msg)
156156
if (srcnode not in newnodes) and not self._has_node(srcnode):
157-
newnodes.append(srcnode)
157+
newnodes.add(srcnode)
158158
if (destnode not in newnodes) and not self._has_node(destnode):
159-
newnodes.append(destnode)
159+
newnodes.add(destnode)
160160
if newnodes:
161161
self._check_nodes(newnodes)
162162
for node in newnodes:

0 commit comments

Comments
 (0)