Skip to content

Commit cc86fc6

Browse files
committed
Re-arrange Dockerfiles, move fsl_imglob.py to external
1 parent 85bd23d commit cc86fc6

File tree

7 files changed

+17
-14
lines changed

7 files changed

+17
-14
lines changed

circle.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ dependencies:
1919
- if [[ ! -d ~/examples/nipype-fsl_course_data ]]; then wget --retry-connrefused --waitretry=5 --read-timeout=20 --timeout=15 -t 0 -q https://3552243d5be815c1b09152da6525cb8fe7b900a6.googledrive.com/host/0BxI12kyv2olZVUswazA3NkFvOXM/nipype-fsl_course_data.tar.gz && tar xzf nipype-fsl_course_data.tar.gz -C ~/examples/; fi
2020
- if [[ ! -d ~/examples/feeds ]]; then wget --retry-connrefused --waitretry=5 --read-timeout=20 --timeout=15 -t 0 -q https://3552243d5be815c1b09152da6525cb8fe7b900a6.googledrive.com/host/0BxI12kyv2olZVUswazA3NkFvOXM/fsl-5.0.9-feeds.tar.gz && tar xzf fsl-5.0.9-feeds.tar.gz -C ~/examples/; fi
2121
- if [[ -e ~/docker/image.tar ]]; then docker load -i ~/docker/image.tar; fi
22-
- docker build -f docker/nipype_test_py35/Dockerfile -t nipype/nipype_test:py35 . :
22+
- docker build -f docker/nipype_test/Dockerfile_py35 -t nipype/nipype_test:py35 . :
2323
timeout: 1600
2424
- mkdir -p ~/docker; docker save nipype/nipype_test:py35 > ~/docker/image.tar :
2525
timeout: 1600

docker/nipype_test_base/Dockerfile renamed to docker/nipype_test/Dockerfile_base

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ FROM neurodebian:latest
3030
MAINTAINER Nipype developers
3131

3232
# Preparations
33-
3433
ARG DEBIAN_FRONTEND=noninteractive
3534
RUN sed -i -e 's,main$,main contrib non-free,g' /etc/apt/sources.list.d/neurodebian.sources.list && \
3635
apt-get -y update && \
@@ -92,9 +91,9 @@ RUN curl -sSL http://www.fil.ion.ucl.ac.uk/spm/download/restricted/utopia/dev/sp
9291
unzip spm12.zip && \
9392
rm -rf spm12.zip
9493

95-
ENV MATLABCMD "/opt/mcr/v85/toolbox/matlab"
96-
ENV SPMMCRCMD "/opt/spm12/run_spm12.sh /opt/mcr/v85/ script"
97-
ENV FORCE_SPMMCR 1
94+
ENV MATLABCMD "/opt/mcr/v85/toolbox/matlab" \
95+
SPMMCRCMD "/opt/spm12/run_spm12.sh /opt/mcr/v85/ script" \
96+
FORCE_SPMMCR 1
9897

9998

10099
CMD ["/bin/bash"]

docker/nipype_test_py34/Dockerfile renamed to docker/nipype_test/Dockerfile_py34

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -48,19 +48,23 @@ ENV LC_ALL C.UTF-8
4848
RUN conda config --add channels conda-forge && \
4949
conda update -y conda && \
5050
conda update --all -y python=3.4 && \
51-
conda install -y lockfile nipype
51+
conda install -y lockfile nipype matplotlib sphinx boto boto3 coverage mock pbr nitime dipy && \
52+
pip install nose-cov doctest-ignore-unicode configparser
53+
54+
COPY docker/circleci/run_* /usr/bin/
55+
RUN chmod +x /usr/bin/run_*
5256

5357
RUN mkdir -p /root/src/nipype
5458
COPY . /root/src/nipype
5559

56-
RUN cd /root/src/nipype && \
57-
pip install nose-cov doctest-ignore-unicode && \
60+
RUN rm -r /usr/local/miniconda/lib/python3.5/site-packages/nipype* && \
61+
cd /root/src/nipype && \
5862
pip install -r requirements.txt && \
59-
pip install -e .
60-
63+
pip install -e . && \
64+
make specs
6165

62-
COPY docker/circleci/run_* /usr/bin/
63-
RUN chmod +x /usr/bin/run_*
64-
ENV SHELL /bin/bash
66+
# Replace imglob with Python3 compatible version
67+
RUN rm -r ${FSLDIR}/bin/imglob && \
68+
ln -s $(which fsl_imglob.py) ${FSLDIR}/bin/imglob
6569

6670
CMD ["/bin/bash"]
File renamed without changes.

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ def main(**extra_args):
434434
# python -- duplicating things into MANIFEST.in but this is admittedly
435435
# only a workaround to get things started -- not a solution
436436
package_data={'nipype': testdatafiles},
437-
scripts=glob('bin/*'),
437+
scripts=glob('bin/*') + ['nipype/external/fsl_imglob.py'],
438438
cmdclass=cmdclass,
439439
**extra_args
440440
)

0 commit comments

Comments
 (0)