chore: revise versioning handling in docker build and Circleci

Author: oesteban

.circleci/config.yml

@@ -41,15 +41,22 @@ jobs:
                   docker push localhost:5000/ubuntu
               fi
       - checkout
+      - run:
+          name: Prepare a Python environment
+          command: |
+              pyenv local 3.7.0
+              python3 -m pip install "setuptools ~= 42.0" "setuptools_scm[toml] >= 3.4" "pip>=10.0.1"
       - run:
           name: Build Docker image & push to registry
           no_output_timeout: 60m
           command: |
+              pyenv local 3.7.0
               e=1 && for i in {1..5}; do
                   docker build --rm --cache-from=nitransforms:latest \
                   -t nitransforms:latest \
                   --build-arg BUILD_DATE=`date -u +"%Y-%m-%dT%H:%M:%SZ"` \
-                  --build-arg VCS_REF=`git rev-parse --short HEAD` . \
+                  --build-arg VCS_REF=`git rev-parse --short HEAD` \
+                  --build-arg VERSION=$( python3 setup.py --version ) . \
                   && e=0 && break || sleep 15
               done && [ "$e" -eq "0" ]
               docker tag nitransforms:latest localhost:5000/nitransforms
@@ -67,7 +74,6 @@ jobs:
           name: Check version packaged in Docker image
           command: |
               pyenv local 3.7.0
-              python3 -m pip install "setuptools ~= 42.0" "setuptools_scm[toml] >= 3.4" "pip>=10.0.1"
               THISVERSION=${CIRCLE_TAG:-$(python3 setup.py --version)}
               INSTALLED_VERSION=$(\
                 docker run -it --rm --entrypoint=python nitransforms \

Dockerfile

@@ -131,12 +131,10 @@ WORKDIR /home/neuro
 ENV HOME="/home/neuro"
 
 # Install package
+# CRITICAL: Make sure python setup.py --version has been run at least once
+#           outside the container, with access to the git history.
 COPY . /src/nitransforms
-ARG VERSION
-# Force static versioning within container
-RUN echo "${VERSION}" > /src/nitransforms/nitransforms/VERSION && \
-    echo "include nitransforms/VERSION" >> /src/nitransforms/MANIFEST.in && \
-    pip install --no-cache-dir "/src/nitransforms[all]"
+RUN pip install --no-cache-dir "/src/nitransforms[all]"
 
 RUN find $HOME -type d -exec chmod go=u {} + && \
     find $HOME -type f -exec chmod go=u {} +