fixed issue with multiple input conns to same node

Author: tclose

nipype2pydra/statements/workflow_build.py

@@ -2,6 +2,7 @@
 import re
 import typing as ty
 import inspect
+import logging
 from operator import attrgetter
 import attrs
 from ..utils import extract_args
@@ -11,6 +12,9 @@
     from ..workflow import WorkflowConverter
 
 
+logger = logging.getLogger(__name__)
+
+
 @attrs.define
 class AssignmentStatement:
 
@@ -368,7 +372,28 @@ def add_input_connection(self, conn: ConnectionStatement):
         bool
             whether the connection is an input of the workflow
         """
-
+        # Ensure that there is only 1 non-conditional connection to the input
+        if not conn.conditional:
+            try:
+                prev = next(
+                    c
+                    for c in self.in_conns
+                    if c.target_in == conn.target_in and not c.conditional
+                )
+            except StopIteration:
+                pass
+            else:
+                logger.warning(
+                    "'%s' input field of '%s' node receives multiple connections: "
+                    "replacing %s:%s with %s:%s",
+                    conn.target_in,
+                    self.name,
+                    prev.source_name,
+                    prev.source_out,
+                    conn.source_name,
+                    conn.source_out,
+                )
+                self.in_conns.remove(prev)
         self.in_conns.append(conn)
 
     def add_output_connection(self, conn: ConnectionStatement) -> bool:

nipype2pydra/workflow.py

@@ -317,7 +317,9 @@ class WorkflowConverter:
     nodes: ty.Dict[str, ty.List[AddInterfaceStatement]] = attrs.field(
         factory=dict, repr=False
     )
-    _unprocessed_connections: ty.List[ConnectionStatement] = attrs.field(factory=list, repr=False)
+    _unprocessed_connections: ty.List[ConnectionStatement] = attrs.field(
+        factory=list, repr=False
+    )
     _input_mapping: ty.Dict[str, WorkflowInput] = attrs.field(
         factory=dict,
         init=False,