ENH: Use explicit name for image type argument in FAST (#62)

ghisvail · tclose · commit cb8841c6d1f3 · 2024-03-25T12:49:32.000+11:00
Use T1, T2 and PD and convert to 1, 2, 3 under the hood.
diff --git a/src/pydra/tasks/fsl/fast.py b/src/pydra/tasks/fsl/fast.py
@@ -28,12 +28,13 @@ class FASTSpec(pydra.specs.ShellSpec):
         }
     )
 
-    image_type: int = attrs.field(
-        default=1,
+    image_type: str = attrs.field(
+        default="T1",
         metadata={
-            "help_string": "type of input image(s) (1: T1, 2: T2, 3: PD)",
+            "help_string": "type of input image (T1, T2 or PD)",
             "argstr": "-t",
-            "allowed_values": {1, 2, 3},
+            "allowed_values": {"T1", "T2", "PD"},
+            "formatter": lambda image_type: "-t {:d}".format({"T1": 1, "T2": 2, "PD": 3}.get(image_type)),
         },
     )
 

Original file line number	Diff line number	Diff line change
`@@ -28,12 +28,13 @@ class FASTSpec(pydra.specs.ShellSpec):`
`28`	`28`	`}`
`29`	`29`	`)`
`30`	`30`
`31`		`- image_type: int = attrs.field(`
`32`		`- default=1,`
	`31`	`+ image_type: str = attrs.field(`
	`32`	`+ default="T1",`
`33`	`33`	`metadata={`
`34`		`- "help_string": "type of input image(s) (1: T1, 2: T2, 3: PD)",`
	`34`	`+ "help_string": "type of input image (T1, T2 or PD)",`
`35`	`35`	`"argstr": "-t",`
`36`		`- "allowed_values": {1, 2, 3},`
	`36`	`+ "allowed_values": {"T1", "T2", "PD"},`
	`37`	`+ "formatter": lambda image_type: "-t {:d}".format({"T1": 1, "T2": 2, "PD": 3}.get(image_type)),`
`37`	`38`	`},`
`38`	`39`	`)`
`39`	`40`