fix tests that test relative cache paths

Author: nicolocin

pydra/engine/tests/test_helpers_file.py

@@ -1,4 +1,4 @@
-import os
+import os, sys
 import time
 import warnings
 import pytest

pydra/engine/tests/test_node_task.py

@@ -538,13 +538,13 @@ def test_task_nostate_cachedir(plugin, tmpdir):
     assert results.output.out == 5
 
 
-# TODO: fix path for windows
-@pytest.mark.skipif(sys.platform.startswith("win"), 'windows cache paths are saved differently')
 @pytest.mark.parametrize("plugin", Plugins)
 def test_task_nostate_cachedir_relativepath(tmpdir, plugin):
     """ task with provided cache_dir as relative path"""
     cwd = tmpdir.chdir()
     cache_dir = "test_task_nostate"
+    tmpdir.mkdir(cache_dir)
+
     nn = fun_addtwo(name="NA", a=3, cache_dir=cache_dir)
     assert np.allclose(nn.inputs.a, [3])
     assert nn.state is None

pydra/engine/tests/test_shelltask.py

@@ -2,7 +2,7 @@
 
 import attr
 import typing as ty
-import os, shutil
+import os, sys, shutil
 import pytest
 from pathlib import Path
 
@@ -13,7 +13,7 @@
 from ..specs import ShellOutSpec, ShellSpec, SpecInfo, File
 
 
-if not sys.platform.startswith("win"):
+if sys.platform.startswith("win"):
     pytest.skip("SLURM not available in windows", allow_module_level=True)
 
 if bool(shutil.which("sbatch")):

pydra/engine/tests/test_task.py

@@ -350,7 +350,6 @@ def testfunc(a: int, b: float = 0.1) -> ty.NamedTuple("Output", [("out", float)]
     assert (tmpdir / funky.checksum / "messages.jsonld").exists()
 
 
-@pytest.mark.skipif(sys.platform.startswith("win"), "skip shell tasks for windows")
 def test_shell_cmd(tmpdir):
     cmd = ["echo", "hail", "pydra"]
 

pydra/engine/tests/test_workflow.py

@@ -1982,12 +1982,13 @@ def test_wf_nostate_cachedir(plugin, tmpdir):
 
 
 # TODO: fix path for windows
-@pytest.mark.skipif(sys.platform.startswith("win"), "failing for windows, something to do with paths?")
+#@pytest.mark.skipif(sys.platform.startswith("win"), reason="failing for windows, something to do with paths?")
 @pytest.mark.parametrize("plugin", Plugins)
 def test_wf_nostate_cachedir_relativepath(tmpdir, plugin):
     """ wf with provided cache_dir as relative path"""
     tmpdir.chdir()
     cache_dir = "test_wf_cache_2"
+    tmpdir.mkdir(cache_dir)
 
     wf = Workflow(name="wf_2", input_spec=["x", "y"], cache_dir=cache_dir)
     wf.add(multiply(name="mult", x=wf.lzin.x, y=wf.lzin.y))