debugging test_tasks

Author: tclose

pydra/design/shell.py

@@ -108,7 +108,11 @@ def _validate_sep(self, _, sep):
         else:
             tp = self.type
         origin = ty.get_origin(tp) or tp
-        if inspect.isclass(origin) and issubclass(origin, ty.Iterable):
+        if (
+            inspect.isclass(origin)
+            and issubclass(origin, ty.Sequence)
+            and tp is not str
+        ):
             if sep is None:
                 raise ValueError(
                     f"A value to 'sep' must be provided when type is iterable {tp} "

pydra/engine/core.py

@@ -457,7 +457,7 @@ def done(self):
         if _result:
             if _result.errored:
                 self._errored = True
-                raise ValueError(f"Task {self.name} raised an error")
+                raise ValueError(f"Task {self.name!r} raised an error")
             else:
                 return True
         return False

pydra/engine/specs.py

@@ -748,7 +748,7 @@ def _from_task(cls, task: "Task[WorkflowDef]") -> Self:
                     if not err_files:
                         raise
                     raise ValueError(
-                        f"Task {lazy_field._node.name} raised an error, full crash report is "
+                        f"Task {lazy_field._node.name!r} raised an error, full crash report is "
                         f"here: "
                         + (
                             str(err_files[0])

pydra/engine/submitter.py

@@ -491,13 +491,13 @@ def tasks(self) -> ty.Iterable["Task[DefType]"]:
             self._tasks = {t.state_index: t for t in self._generate_tasks()}
         return self._tasks.values()
 
-    def task(self, index: StateIndex | None = None) -> "Task | list[Task[DefType]]":
+    def task(self, index: StateIndex = StateIndex()) -> "Task | list[Task[DefType]]":
         """Get a task object for a given state index."""
         self.tasks  # Ensure tasks are loaded
         try:
             return self._tasks[index]
         except KeyError:
-            if index is None:
+            if not index:
                 return StateArray(self._tasks.values())
             raise
 

pydra/engine/tests/test_task.py

@@ -1351,14 +1351,8 @@ def test_traceback(tmpdir):
     def FunError(x):
         raise Exception("Error from the function")
 
-    task = Task(
-        name="error",
-        definition=FunError().split("x", x=[3, 4]),
-        submitter=Submitter(cache_dir=tmpdir),
-    )
-
-    with pytest.raises(Exception, match="from the function") as exinfo:
-        task.run()
+    with pytest.raises(Exception, match="Task 'FunError' raised an error") as exinfo:
+        FunError(x=3)(worker="cf", cache_dir=tmpdir)
 
     # getting error file from the error message
     error_file_match = str(exinfo.value).split("here: ")[-1].split("_error.pklz")[0]
@@ -1383,12 +1377,12 @@ def FunError(x):
         raise Exception("Error from the function")
 
     @workflow.define
-    def Workflow(x):
-        error = workflow.add(FunError(x=x), name="error")
-        return error.out
+    def Workflow(x_list):
+        fun_error = workflow.add(FunError().split(x=x_list), name="fun_error")
+        return fun_error.out
 
-    wf = Workflow().split("x", x=[3, 4])
-    with pytest.raises(Exception, match="Task error raised an error") as exinfo:
+    wf = Workflow(x_list=[3, 4])
+    with pytest.raises(Exception, match="Task 'fun_error' raised an error") as exinfo:
         wf(worker="cf")
 
     # getting error file from the error message
@@ -1463,7 +1457,7 @@ class Defn(ShellDef["Defn.Outputs"]):
         a1_field: str
         b2_field: float
         c3_field: ty.Dict[str, str]
-        d4_field: ty.List[str]
+        d4_field: ty.List[str] = shell.arg(sep=" ")
         executable = "dummy"
 
         class Outputs(ShellOutputs):