Skip to content

Commit 5f71205

Browse files
committed
removing asserts for time of execution, for slurm it doesn't work very well
1 parent 6263b06 commit 5f71205

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

pydra/engine/tests/test_workflow.py

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2104,8 +2104,6 @@ def test_wf_nostate_cachelocations_wftaskrerun_propagateFalse(plugin, tmpdir):
21042104
# tasks should not be recomputed
21052105
assert len(list(Path(cache_dir1).glob("F*"))) == 2
21062106
assert len(list(Path(cache_dir2).glob("F*"))) == 0
2107-
assert t1 > 3
2108-
assert t2 < 1
21092107

21102108

21112109
@pytest.mark.parametrize("plugin", Plugins)
@@ -2213,14 +2211,10 @@ def test_wf_nostate_nodecachelocations(plugin, tmpdir):
22132211
results2 = wf2.result()
22142212
assert 12 == results2.output.out
22152213

2216-
# checking execution time
2217-
assert t1 > 3
2218-
assert t2 < 0.5
2219-
22202214
# checking if the second wf runs again, but runs only one task
22212215
assert wf1.output_dir.exists()
22222216
assert wf2.output_dir.exists()
2223-
2217+
# the second wf should rerun one task
22242218
assert len(list(Path(cache_dir1).glob("F*"))) == 2
22252219
assert len(list(Path(cache_dir2).glob("F*"))) == 1
22262220

@@ -2270,12 +2264,9 @@ def test_wf_nostate_nodecachelocations_upd(plugin, tmpdir):
22702264
# checking if the second wf runs again, but runs only one task
22712265
assert wf1.output_dir.exists()
22722266
assert wf2.output_dir.exists()
2273-
2267+
# the second wf should have only one task run
22742268
assert len(list(Path(cache_dir1).glob("F*"))) == 2
22752269
assert len(list(Path(cache_dir2).glob("F*"))) == 1
2276-
# checking execution time
2277-
assert t1 > 3
2278-
assert t2 < 0.5
22792270

22802271

22812272
@pytest.mark.parametrize("plugin", Plugins)
@@ -2639,9 +2630,9 @@ def test_wf_nostate_cachelocations_recompute(plugin, tmpdir):
26392630
assert wf1.output_dir.exists()
26402631
assert wf2.output_dir.exists()
26412632

2642-
# checking execution time (second task shouldn't be recompute, t2 should be small)
2643-
assert t1 > 3
2644-
assert t2 < 1
2633+
# the second wf should have only one task run
2634+
assert len(list(Path(cache_dir1).glob("F*"))) == 2
2635+
assert len(list(Path(cache_dir2).glob("F*"))) == 1
26452636

26462637

26472638
@pytest.mark.parametrize("plugin", Plugins)

0 commit comments

Comments
 (0)