Refactor test

Author: ablachair

pydra/engine/tests/test_specs.py

@@ -372,10 +372,7 @@ def test_input_file_hash_5(tmpdir):
     hash3 = inputs(in_file=[{"file": file_diffcontent, "int": 3}]).hash
     assert hash1 != hash3
 
-
-
-def test_task_inputs_mandatory_with_xOR_TF():
-    """input spec with mandatory inputs"""
+class SimpleTask(ShellCommandTask):
     input_fields=[
             (
                 "input_1",
@@ -401,49 +398,33 @@ def test_task_inputs_mandatory_with_xOR_TF():
     task_output_fields = []
     task_output_spec = SpecInfo(name="Output", fields=task_output_fields, bases=(ShellOutSpec,))
 
-    class MyTask(ShellCommandTask):
-        input_spec = task_input_spec
-        output_spec = task_output_spec
-        executable = "cmd"
+    input_spec = task_input_spec
+    output_spec = task_output_spec
+    executable = "cmd"
 
-    task = MyTask()
+
+def test_task_inputs_mandatory_with_xOR_one_mandatory_is_enough():
+    """input spec with mandatory inputs"""
+    task = SimpleTask()
     task.inputs.input_1 = True
     task.inputs.input_2 = attr.NOTHING
     task.inputs.check_fields_input_spec()
 
-def test_task_inputs_mandatory_with_xOR_TT():
+def test_task_inputs_mandatory_with_xOR_zero_mandatory_raises_error():
     """input spec with mandatory inputs"""
-    input_fields=[
-            (
-                "input_1",
-                bool,
-                {
-                    "help_string": "help",
-                    "mandatory": True,
-                    "xor": ("input_1", "input_2"),
-                }
-            ),
-            (
-                "input_2",
-                bool,
-                {
-                    "help_string": "help",
-                    "mandatory": True,
-                    "argstr": "--i2",
-                    "xor": ("input_1", "input_2"),
-                }
-    )
-    ]
-    task_input_spec = SpecInfo(name="Input", fields=input_fields, bases=(ShellSpec,))
-    task_output_fields = []
-    task_output_spec = SpecInfo(name="Output", fields=task_output_fields, bases=(ShellOutSpec,))
+    task = SimpleTask()
+    task.inputs.input_1 = attr.NOTHING
+    task.inputs.input_2 = attr.NOTHING
+    task.inputs.check_fields_input_spec()
 
-    class MyTask(ShellCommandTask):
-        input_spec = task_input_spec
-        output_spec = task_output_spec
-        executable = "cmd"
 
-    task = MyTask()
+def test_task_inputs_mandatory_with_xOR_two_mandatories_raises_error():
+    """input spec with mandatory inputs"""
+    task = SimpleTask()
     task.inputs.input_1 = True
     task.inputs.input_2 = True
-    task.inputs.check_fields_input_spec()
+    
+    with pytest.raises(Exception) as excinfo:
+        task.inputs.check_fields_input_spec()
+    assert "input_2 is mutually exclusive with ('input_1', 'input_2')" in str(excinfo.value)
+    assert excinfo.type is AttributeError