REF: Optimize filter in list comprehension

ghisvail · effigies · ghisvail · commit b8b2f50edc01 · 2023-03-13T21:38:49.000+01:00
Co-authored-by: Chris Markiewicz &lt;effigies@gmail.com&gt;
diff --git a/pydra/engine/helpers_file.py b/pydra/engine/helpers_file.py
@@ -597,10 +597,8 @@ def template_update(inputs, output_dir, state_ind=None, map_copyfiles=None):
         for field in attr_fields(inputs)
         if field.metadata.get("output_file_template")
         and all(
-            [
-                getattr(inputs, required_field) is not attr.NOTHING
-                for required_field in field.metadata.get("requires", [])
-            ]
+            getattr(inputs, required_field) is not attr.NOTHING
+            for required_field in field.metadata.get("requires", ())
         )
     ]
 

Original file line number	Diff line number	Diff line change
`@@ -597,10 +597,8 @@ def template_update(inputs, output_dir, state_ind=None, map_copyfiles=None):`
`597`	`597`	`for field in attr_fields(inputs)`
`598`	`598`	`if field.metadata.get("output_file_template")`
`599`	`599`	`and all(`
`600`		`- [`
`601`		`- getattr(inputs, required_field) is not attr.NOTHING`
`602`		`- for required_field in field.metadata.get("requires", [])`
`603`		`- ]`
	`600`	`+ getattr(inputs, required_field) is not attr.NOTHING`
	`601`	`+ for required_field in field.metadata.get("requires", ())`
`604`	`602`	`)`
`605`	`603`	`]`
`606`	`604`