Add test for pydracli crash

Author: Wu Jianxiao

pydra/conftest.py

@@ -1,6 +1,8 @@
 import shutil
 import os
 import pytest
+import typing as ty
+from click.testing import CliRunner, Result as CliResult
 
 os.environ["NO_ET"] = "true"
 
@@ -41,17 +43,39 @@ def pytest_generate_tests(metafunc):
         metafunc.parametrize("any_worker", available_workers)
 
 
+@pytest.fixture
+def cli_runner(catch_cli_exceptions: bool) -> ty.Callable[..., ty.Any]:
+    def invoke(
+        *args: ty.Any, catch_exceptions: bool = catch_cli_exceptions, **kwargs: ty.Any
+    ) -> CliResult:
+        runner = CliRunner()
+        result = runner.invoke(*args, catch_exceptions=catch_exceptions, **kwargs)  # type: ignore[misc]
+        return result
+
+    return invoke
+
+
 # For debugging in IDE's don't catch raised exceptions and let the IDE
 # break at it
-if os.getenv("_PYTEST_RAISE", "0") != "0":  # pragma: no cover
+if os.getenv("_PYTEST_RAISE", "0") != "0":
+
+    @pytest.hookimpl(tryfirst=True)
+    def pytest_exception_interact(call: pytest.CallInfo[ty.Any]) -> None:
+        if call.excinfo is not None:
+            raise call.excinfo.value
+
+    @pytest.hookimpl(tryfirst=True)
+    def pytest_internalerror(excinfo: pytest.ExceptionInfo[BaseException]) -> None:
+        raise excinfo.value
+
+    CATCH_CLI_EXCEPTIONS = False
+else:
+    CATCH_CLI_EXCEPTIONS = True
 
-    @pytest.hookimpl(tryfirst=True)  # pragma: no cover
-    def pytest_exception_interact(call):  # pragma: no cover
-        raise call.excinfo.value  # pragma: no cover
 
-    @pytest.hookimpl(tryfirst=True)  # pragma: no cover
-    def pytest_internalerror(excinfo):  # pragma: no cover
-        raise excinfo.value  # pragma: no cover
+@pytest.fixture
+def catch_cli_exceptions() -> bool:
+    return CATCH_CLI_EXCEPTIONS
 
 
 # Example VSCode launch configuration for debugging unittests

pydra/scripts/tests/test_crash.py

@@ -0,0 +1,24 @@
+from pydra.scripts.cli import crash
+from pydra.utils.general import default_run_cache_root
+from pydra.tasks.testing import Divide
+from traceback import format_exception
+import typing as ty
+
+
+# @pytest.mark.xfail(reason="Need to fix a couple of things after syntax changes")
+def test_crash_cli(cli_runner):
+    result = cli_runner(
+        crash,
+        [
+            f"{default_run_cache_root}/{Divide(x=15, y=0)._checksum}/_error.pklz",
+            "--rerun",
+            "--debugger",
+            "pdb",
+        ],
+    )
+    assert result.exit_code == 0, show_cli_trace(result)
+
+
+def show_cli_trace(result: ty.Any) -> str:
+    "Used in testing to show traceback of CLI output"
+    return "".join(format_exception(*result.exc_info))