added test to hit graph is not empty error due to input objects being altered

Author: tclose

pydra/engine/tests/test_submitter.py

@@ -1,7 +1,5 @@
 from dateutil import parser
 import re
-import shutil
-import attrs
 import subprocess as sp
 import time
 
@@ -579,33 +577,41 @@ def test_sge_no_limit_maxthreads(tmpdir):
     assert job_1_endtime > job_2_starttime
 
 
-@mark.task
-def add_together(x, y):
-    return x + y
-
-
 def test_wf_with_blocked_tasks(tmpdir):
-    dummy_task = add_together(name="dummy", x=1, y=2)
-    lf = LazyField(node=dummy_task, attr_type="output")
-    lf.field = "out"
     wf = Workflow(name="wf_with_blocked_tasks", input_spec=["x"])
-    wf.add(sleep_add_one(name="taska", x=wf.lzin.x))
-    wf.add(sleep_add_one(name="taskb", x=lf))  # wf.taska.lzout.out))
-    # wf.add(sleep_add_one(name="taskc", x=wf.taska.lzout.out))
-    # wf.add(add_together(name="taskd", x=wf.taskb.lzout.out, y=wf.taskc.lzout.out))
+    wf.add(identity(name="taska", x=wf.lzin.x))
+    wf.add(alter_input(name="taskb", x=wf.taska.lzout.out))
+    wf.add(to_tuple(name="taskc", x=wf.taska.lzout.out, y=wf.taskb.lzout.out))
     wf.set_output([("out", wf.taskb.lzout.out)])
 
-    wf.inputs.x = 1
+    wf.inputs.x = A(1)
 
     wf.cache_dir = tmpdir
 
-    with Submitter("serial") as sub:
-        sub(wf)
+    with pytest.raises(Exception, match="graph is not empty,"):
+        with Submitter("serial") as sub:
+            sub(wf)
+
+
+class A:
+    def __init__(self, a):
+        self.a = a
+
+    def __hash__(self):
+        return hash(self.a)
 
-    # with pytest.raises(Exception) as exc:
-    # wf_graph = wf.graph.copy()
-    # runnable_tasks, _ =  get_runnable_tasks(wf_graph)
-    # assert runnable_tasks == []
-    # blocked = _list_blocked_tasks(wf_graph)
 
-    # assert "graph is not empty" in str(exc)
+@mark.task
+def identity(x):
+    return x
+
+
+@mark.task
+def alter_input(x):
+    x.a = 2
+    return x
+
+
+@mark.task
+def to_tuple(x, y):
+    return (x, y)